[18.0][MIG] crm_won_reason: Migration to 18.0 #658
Conversation
Currently translated at 100.0% (20 of 20 strings) Translation: crm-15.0/crm-15.0-crm_won_reason Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_won_reason/es/
apami0111
force-pushed
the
18.0-mig-crm_won_reason
branch
3 times, most recently
from
3557b0d to
f16ea9c
Compare
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Two "Won" buttons are being displayed.
|
@BhaveshHeliconia Thank you for the feedback. I have reviewed the case and confirm that the crm_won_reason module by itself does not present the issue of two "Won" buttons. This behavior only occurs when it is installed together with the crm_won_restrict_per_stage module, as both apply an invisible attribute to the same button, causing the view to be triggered and resulting in two instances of the button being displayed. |
|
@apami0111 : The functionality works perfectly, but having the same "Won" label for both buttons can be confusing. |
celm1990
left a comment
celm1990
left a comment
There was a problem hiding this comment.
LGTM
@pedrobaeza could you review this?
|
/ocabot migration crm_won_reason |
crm_won_reason/__manifest__.py
Outdated
| "website": "https://github.com/OCA/crm", | ||
| "license": "AGPL-3", | ||
| "depends": [ | ||
| "base", |
There was a problem hiding this comment.
Thank you very much for your observation! @jaenbox
I've already made the change.
apami0111
force-pushed
the
18.0-mig-crm_won_reason
branch
from
f16ea9c to
69c5c63
Compare
|
ping @pedrobaeza |
|
@BhaveshHeliconia has requested changes |
|
@pedrobaeza Thanks for the note. The issue mentioned in
the duplicated “Won” button was not caused by crm_won_reason, but by its interaction with crm_won_restrict_per_stage, since both apply an invisible attribute to the same button. With only crm_won_reason installed, everything works correctly. |
|
Yeah, but he should confirm it. |
10 participants
attrswith newinvisibleexpression incrm_won_reason/views/crm_views.xml: