-
-
Notifications
You must be signed in to change notification settings - Fork 456
[IMP] crm_lead_to_task: Usability improves #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
e2307f3 to
3948f3d
Compare
After merging “crm_project_task,” some usability issues were reported. The following improvements have been added: - Unified to a button in the lead with a wizard that always appears - If a project is selected in the options, it will open by default in the wizard in read-only mode - Within the wizard, you can: - Convert lead to task: this is how it worked before, where you can archive the lead and move the chatter to the task - Create task and link: a task linked to the lead will be created, but the chatter will not be moved and the lead will not be archived. @moduon MT-11907
3948f3d to
fdaef82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for this improvements 🙏🏼
- Please be sure we solve #481
- Add Moduon as author of the module and maintain the contributor and maintainers of https://github.com/OCA/crm/tree/16.0/crm_project_task
Thank you! 😄 ❤️
| <record id="crm_lead_convert2task_view_form" model="ir.ui.view"> | ||
| <field name="model">crm.lead.convert2task</field> | ||
| <field name="arch" type="xml"> | ||
| <form string="Convert to Task"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: this form title is now misleading
| action["context"] = context | ||
| return action | ||
|
|
||
| def _move_chatter(self, task): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: remember that many modules can coexist, so it's better if method names are more explicit:
| def _move_chatter(self, task): | |
| def _move_chatter_to_task(self, task): |
| if self.company_id.crm_archive_lead_on_convert: | ||
| self.active = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: does this make sense now? If users have the ability to click on "convert to task", shouldn't that just archive always?
IMHO the crm_archive_lead_on_convert should be an option with 3 choices:
- Always
- Never
- Empty (let the user choose)
| type="object" | ||
| string="Create Task" | ||
| class="oe_stat_button" | ||
| groups="project.group_project_user" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

After merging “crm_project_task,” some usability issues were reported. The following improvements have been added:
https://www.loom.com/share/142ac524c4274a75b6aef5d1ef6feb5b
@moduon MT-11907