-
-
Notifications
You must be signed in to change notification settings - Fork 456
[16.0][ADD] crm_stage_validation: add new module #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
f152c22 to
b6f75e5
Compare
kaynnan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rrebollo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Review: LGTM
Thank you for your valuable contribution. The feature addresses a clear need within the validation workflow scope.
For several versions now, Odoo/OCA has maintained a robust framework for this type of requirement: tier_validation (from the OCA/server-ux repository). A module like crm_stage_tier_validation would likely be well-received by the community, as it would expand the feature beyond basic field validation into a more comprehensive approval system.
Please don't misunderstand — this is excellent work and represents a key functionality. It actually raises a broader question: why isn't this already part of the vanilla system?
If merged, this PR would certainly be a valuable addition. However, from a long-term and community-wide perspective, I believe enriching established tools like tier_validation is often more sustainable than creating new, separate solutions. This approach helps consolidate efforts and avoids fragmentation.
With that said, would you be open to reviewing my PR #661? It's also an addition, so please feel free to question or comment on any aspect of it. I welcome your perspective.
Thank you again for your work and collaboration.
WesleyOliveira98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODE REVIEW - OK
|
This PR has the |
b6f75e5 to
9494944
Compare
9494944 to
7afa959
Compare
This module extends the CRM functionality by allowing you to validate that specific fields are filled when moving a lead/opportunity to a certain stage.
Main Features
Benefits
Dependencies
This module requires:
crm: Odoo's CRM module