[18.0][MIG] maintenance_location: Migration to 18.0 #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypapouin
force-pushed
the
18.0-mig-maintenance_location
branch
from
6445f8d to
61c17c8
Compare
…t_selection dependency
Currently translated at 100.0% (32 of 32 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_location Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_location/it/
Fix oca-checks-po:po-duplicate-model-definition
ypapouin
force-pushed
the
18.0-mig-maintenance_location
branch
from
61c17c8 to
ae4e821
Compare
Quan-nhm
suggested changes
Dec 26, 2025
| @api.constrains("parent_id") | ||
| def _check_category_recursion(self): | ||
| if self._has_cycle(): | ||
| raise ValidationError(_("Error ! You cannot create recursive Locations.")) |
There was a problem hiding this comment.
should change from _ to self.env._
it belong to the migration guides of version 18.0
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
You can replace the call to translate a string () with self.env. for getting some performance improvement in some cases. See odoo/odoo#174844.
You should also remove the import _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: