[18.0][IMP] rma: Add _get_location_final() method to be able to use it in other modules

[victoralmau]

Add _get_location_final() method to be able to use it in other modules

Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?

@Tecnativa TT57139

[OCA-git-bot]

Hi @pedrobaeza, @chienandalu,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

Shouldn't this be called _get_final_location_dest?

[victoralmau]

Shouldn't this be called _get_final_location_dest?

Okay, changed. The name of the method _get_location_final() was similar to the one that exists in sale_stock: https://github.com/odoo/odoo/blob/aad8a4a25f5d251b48e4f1894ee113176abdc834/addons/sale_stock/models/sale_order_line.py#L308

[pedrobaeza]

Ah, OK, didn't know that analogy. You can comment that on the commit message/code for knowing about your inspiration. Yet, I think Odoo didn't choose the best name for it, don't you think? Anyway, if you think it's better to put the same name, just add the comment. What you prefer.

[carlos-lopez-tecnativa]

LGTM

[victoralmau]

IMO the name _get_location_final() is not incorrect, because it represents reality, the value that will be defined in location_final_id. I have added the appropriate comment in the method to clarify this.

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-515-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 984018a. Thanks a lot for contributing to OCA. ❤️