This repository was archived by the owner on Sep 16, 2024. It is now read-only.
[FIX] runbot_travis2docker: Fix compatibility for url without https prefix #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
force-pushed
the
9.0-oca-https-moy
branch
from
861d29f to
0dc83f9
Compare
lasley
reviewed
Nov 10, 2016
|
|
||
| <record id="runbot_repo_demo1" model="runbot.repo"> | ||
| <field name="name">github.com/vauxoo-dev/fast-travis-test.git</field> | ||
| <field name="name">https://github.com/vauxoo-dev/fast-travis-test.git</field> |
Contributor
There was a problem hiding this comment.
I don't think the code is working if this data didn't work. The repo name didn't start with https:// or git@, so shouldn't the https have been appended automatically?
Contributor
Author
There was a problem hiding this comment.
The error is because travis is using the original repo of odoo/odoo-extra without the following patch: odoo/odoo-extra#74 used on OCA Runbot server
Contributor
Author
|
FYI I just ran a t2d of runbot but using:
|
alan196
approved these changes
Nov 11, 2016
jjscarafia
approved these changes
Nov 11, 2016
pedrobaeza
approved these changes
Nov 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the following patch: gurneyalex/odoo-extra@92b578a
But runbot_travis2docker is not working with this one
Fix #105