[19.0] [MIG] impersonate_login: migrate + tests #847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoided requiring the module twice in JS.
Currently translated at 57.9% (22 of 38 strings) Translation: server-auth-12.0/server-auth-12.0-password_security Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-password_security/hr/
…rity and website module installed.
Currently translated at 86.8% (33 of 38 strings) Translation: server-auth-12.0/server-auth-12.0-password_security Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-password_security/pt/
Currently translated at 100.0% (38 of 38 strings) Translation: server-auth-12.0/server-auth-12.0-password_security Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-password_security/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-12.0/server-auth-12.0-password_security Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-password_security/
Set requirements in the root of projects
Currently translated at 100.0% (56 of 56 strings) Translation: server-auth-14.0/server-auth-14.0-password_security Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-password_security/fi/
Currently translated at 26.7% (15 of 56 strings) Translation: server-auth-14.0/server-auth-14.0-password_security Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-password_security/sv/
Currently translated at 39.2% (22 of 56 strings) Translation: server-auth-14.0/server-auth-14.0-password_security Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-password_security/sv/
When using mapping, not writing the value systematically avoids getting security mail on login/email changes when there is no change. Also use SQL for blanking passwords avoids the security update mails.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-18.0/server-auth-18.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-18-0/server-auth-18-0-auth_saml/
Currently translated at 100.0% (93 of 93 strings) Translation: server-auth-18.0/server-auth-18.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-18-0/server-auth-18-0-auth_saml/it/
legalsylvain
requested changes
Oct 10, 2025
Contributor
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
Hi. Could you respect commit history ?
Thanks !
added 6 commits
October 10, 2025 16:12
- Wrap long lines to satisfy ruff E501 - Use self.env._ for translations; avoid .format in _() - Use lazy named placeholders in translations - Minor JS/style auto-fixes from pre-commit Non-functional changes only (cherry picked from commit 37c900d)
- Use group_ids instead of groups_id - Create demo user if base.user_demo is missing (no demo data) Test-only change (cherry picked from commit 14f4762)
- Add base.group_partner_manager to demo user in setUpClass Test-only change (cherry picked from commit d48ff82)
- Update session markers, logging, and log writes - Silence 19.0 deprecation warnings Non-functional change (cherry picked from commit 10f6882)
tishmen
force-pushed
the
19.0-migrate-impersonate_login
branch
from
10f6882 to
5a3dadd
Compare
added 5 commits
October 10, 2025 16:14
…sonate_from_uid")
Author
|
@legalsylvain Hi, thanks for the note - updated to preserve history. Please review and let me know if there is anything else. |
| ): | ||
| if request and request.session.impersonate_from_uid: | ||
| def _message_compute_author(self, author_id=None, email_from=None): | ||
| # Odoo 19 signature drops `raise_on_email`; adapt accordingly. |
Contributor
There was a problem hiding this comment.
Such comment should be more a commit message. On need to introduce in the code.
Author
|
Closing in favor of #849 (history-preserving 18.0 → 19.0 migration). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Depends on
Summary
self._uidusages; adjust translations and formatting; JS asset integration for backend menu item.Temporary references
Pre-commit
Tests
base.group_user,base.group_partner_manager).--test-tags "/impersonate_login"on a fresh DB.