[18.0][IMP] auth_oidc: add groups' handling #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for 18.0: List views are now 'list' ('tree' until 17.0)
Co-authored-by: Holger Brunn <mail@hunki-enterprises.com>
Contributor
|
Hi @sbidoul, |
OdyX
force-pushed
the
18-auth-oidc-groups-sync
branch
from
af6d71a to
a0abab9
Compare
bizzappdev
pushed a commit
to BizzAppDev-Systems/server-auth
that referenced
this pull request
Nov 5, 2025
…ord invalid (OCA#859) * [FIX] password_security: Fix password stored * [REF] password_security: use a unified check_password private method to validate rules and history password
arif-m150
pushed a commit
to arif-m150/server-auth
that referenced
this pull request
Nov 7, 2025
…ord invalid (OCA#859) * [FIX] password_security: Fix password stored * [REF] password_security: use a unified check_password private method to validate rules and history password
arif-m150
pushed a commit
to arif-m150/server-auth
that referenced
this pull request
Nov 7, 2025
…ord invalid (OCA#859) * [FIX] password_security: Fix password stored * [REF] password_security: use a unified check_password private method to validate rules and history password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows groups' handling via a token's attributes as passed by an OIDC IdP (tested with both Keycloak and Gitlab)
This is the 18.0-version of these pulls by @26houseRobot and @hbrunn, with some minor fixes
It's the same code base as #682 with some fixes & improvements:
validation_endpoint, with corresponding tests (see dad2cd0 & a0abab9).It was a significant hurdle to maintain codecov at "satisfied" levels, but I hope that with this we are all set!