[10] auth_admin_passkey Fix Issue #1227

[mohamedhagag]

this is a fix for issue:
#1227
based on the PR by akretion for 8 and 9 here:
#519

[pedrobaeza]

Please change module version number according https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers

And check travis status

[mohamedhagag]

Version number change will create another PR, is this OK ?

Regarding the travis status I can't find errors related to this module, it complains about other modules like auth_brute_force , auth_user_case_insensitive and other modules.
What should I do ?

Sorry but I'm new in contributing to OSS projects using github.

[pedrobaeza]

@mohamedhagag no, adding version number doesn't create other PR if you do it through git, not via GitHub interface.

And the Travis errores are yours:

auth_admin_passkey/models/res_config.py:8:1: E302 expected 2 blank lines, found 1
auth_admin_passkey/models/res_config.py:17:63: E231 missing whitespace after ','
auth_admin_passkey/models/res_config.py:32:62: E231 missing whitespace after ','

[mohamedhagag]

@pedrobaeza would you plz chk and merge.

[pedrobaeza]

This is not how it works. Check https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md for the general rules. It requires at least 2 reviews, and a way to get reviews is to make another reviews and ask in return to review yours.

[legalsylvain]

Hi,

• you moved a lot of code, that make the diff quite hard to review. I don't see the reason of that ?
• I think adding triple quote is unnecessary.

Other it looks great for me !

[NL66278]

I agree it is a good idea to get rid of the triple quotes. They were introduced in the fix for 8.0.

[NL66278]

I think the latest two commits, using the string 'False' instead of an empty string when setting the parameters, and then testing for string 'True' or '1' when getting the parameters is not needed. The second commit fixes an error introduced by the first commit. Setting the parameter to an empty string effectively sets it to a False or rather falsey value. So original code as now existing in 8.0 just should work IMHO.

[dek-odoo]

are there any updates ? The issue is still there.

[gurneyalex]

superseeded by #1720