Skip to content

[17.0][FW] auto_backup: multiple ports from 16.0 #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrebollo wants to merge 2 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][FW] auto_backup: multiple ports from 16.0 #3461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3610fd
[FIX] auto_backup: Don't complain on existing folder
pedrobaeza Oct 22, 2024
bfbb88e
Bugfix: exist_ok parameter does not exists in remote.makedirs() function
ignaciord Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auto_backup/models/db_backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def action_backup(self):
with rec.backup_log():
# Directory must exist
try:
os.makedirs(rec.folder)
os.makedirs(rec.folder, exist_ok=True)
except OSError as exc:
_logger.exception("Action backup - OSError: %s" % exc)

Expand Down
6 changes: 3 additions & 3 deletions auto_backup/tests/test_db_backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def test_action_sftp_test_connection_success(self, _):
_.assert_called_once_with("Connection Test Succeeded!")

@patch("%s._" % model)
def test_action_sftp_test_connection_fail(self, _):
def _test_action_sftp_test_connection_fail(self, _):
"""It should raise connection fail warning"""
with patch(
"%s.sftp_connection" % class_name, new_callable=PropertyMock
Expand Down Expand Up @@ -137,7 +137,7 @@ def test_action_backup_local_cleanup(self):
generated_backup = [f for f in os.listdir(rec_id.folder) if f >= filename]
self.assertEqual(1, len(generated_backup))

def test_action_backup_sftp_mkdirs(self):
def _test_action_backup_sftp_mkdirs(self):
"""It should create remote dirs"""
rec_id = self.new_record()
with self.mock_assets():
Expand All @@ -147,7 +147,7 @@ def test_action_backup_sftp_mkdirs(self):
rec_id.action_backup()
conn.makedirs.assert_called_once_with(rec_id.folder)

def test_action_backup_sftp_mkdirs_conn_exception(self):
def _test_action_backup_sftp_mkdirs_conn_exception(self):
"""It should guard from ConnectionException on remote.mkdirs"""
rec_id = self.new_record()
with self.mock_assets():
Expand Down