[18.0][IMP] auto_backup: add option to skip host key verification #3482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sftp_ignore_hostkey boolean field to allow users to disable SSH host key verification for SFTP connections. This resolves connection issues when the server's host key is not in the known_hosts file, while keeping verification enabled by default for security. When enabled, a warning is logged to alert administrators that host key verification is disabled. Closes OCA#782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a configurable option
sftp_ignore_hostkeyto allow users to disable SSH host key verification for SFTP connections.Problem
When using SFTP backup method, connections fail with
SSHException: No hostkey for host X foundif the server's host key is not in theknown_hostsfile. This is a common issue reported in #782.Solution
sftp_ignore_hostkey(default:False)Changes
auto_backup/models/db_backup.py: Add field and modifysftp_connection()methodauto_backup/view/db_backup_view.xml: Add field to SFTP settings formauto_backup/tests/test_db_backup.py: Add 3 new tests for the featureTest Plan
Closes #782