-
-
Notifications
You must be signed in to change notification settings - Fork 16
[18.0][FIX] hr_shift: reduce crash when missing data #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][FIX] hr_shift: reduce crash when missing data #26
Conversation
|
This pull request correct this crash. |
david-banon-tecnativa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
465c906 to
877a47b
Compare
|
@david-banon-tecnativa Thanks for your reviews, I implement your proposition. |
|
Thanks, please force push again, CI failed but i don't think its related to the PR |
|
I'm able to relaunch it, so I have done it. Let's see |
|
The check pass after relaunch @pedrobaeza |
|
This PR has the |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 6779953. Thanks a lot for contributing to OCA. ❤️ |
last_plan can be False and default_vals can be empty
fix typo Self #25 (comment)