Skip to content

Conversation

@mathben
Copy link
Contributor

@mathben mathben commented Feb 4, 2026

last_plan can be False and default_vals can be empty
fix typo Self #25 (comment)

@mathben
Copy link
Contributor Author

mathben commented Feb 4, 2026

This pull request correct this crash.
First execution without demo data.

    week_number=default_vals["week_number"],
                ~~~~~~~~~~~~^^^^^^^^^^^^^^^
KeyError: 'week_number'

@pedrobaeza pedrobaeza added this to the 18.0 milestone Feb 4, 2026
Copy link
Contributor

@david-banon-tecnativa david-banon-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments

@mathben mathben force-pushed the 18.0_hr_shift_fix_first_execution branch from 465c906 to 877a47b Compare February 4, 2026 18:03
@mathben
Copy link
Contributor Author

mathben commented Feb 4, 2026

@david-banon-tecnativa Thanks for your reviews, I implement your proposition.

@david-banon-tecnativa
Copy link
Contributor

Thanks, please force push again, CI failed but i don't think its related to the PR

@pedrobaeza
Copy link
Member

I'm able to relaunch it, so I have done it. Let's see

@mathben
Copy link
Contributor Author

mathben commented Feb 10, 2026

The check pass after relaunch @pedrobaeza
Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-26-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8c0292b into OCA:18.0 Feb 10, 2026
9 of 10 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6779953. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants