Skip to content

Conversation

@kobros-tech
Copy link
Contributor

@kobros-tech kobros-tech commented Apr 2, 2025

Because of the nice odoo survey interaction and organized questions and well designed format, there is a need to show the signers a survey and fill, then send them a filled sign request waiting for their approval so that we save time for them and fetch information in an interesting way not a boring one.

The commit is under development and we need to apply the idea in a professional way, and business bearing one!

description, configuration is TODO

based on PR
#91

#102

https://github.com/OCA/survey/#157

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@dnplkndll
Copy link

@kobros-tech I think you want to make a new module for this connector.

I think there needs to be a complete process review too. if the fields are to map from the sign to the survey should that be able to be created from the sign template?

maybe we could use the US streamlines as a demo item since it covers the most US states and would be able to then create the exemption needed for the tex service.

https://www.streamlinedsalestax.org/docs/default-source/forms/exemption-certificateb926a7ab4a0d43e1ad4fe8eb19e79cbb.pdf?sfvrsn=857843d_5

@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from cc24057 to 8c7d389 Compare April 2, 2025 22:51
@kobros-tech
Copy link
Contributor Author

@kobros-tech I think you want to make a new module for this connector.

I think there needs to be a complete process review too. if the fields are to map from the sign to the survey should that be able to be created from the sign template?

maybe we could use the US streamlines as a demo item since it covers the most US states and would be able to then create the exemption needed for the tex service.

https://www.streamlinedsalestax.org/docs/default-source/forms/exemption-certificateb926a7ab4a0d43e1ad4fe8eb19e79cbb.pdf?sfvrsn=857843d_5

now I improved the field item to be just one "Survey" and according to each one of them I compare the placehloder to the key of the answer, video is showing that.

I didn't want to give my suggestion of creating a new module untill you give me the suggetion on it.

I will try to apply other ones too.

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a glue module. do not add the dependancy here

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to #99 (review), I believe the module could be similar to maintenance_sign_oca. Besides, it seems that what is commented in #91 (comment) will also be necessary, right?

@kobros-tech
Copy link
Contributor Author

In addition to #99 (review), I believe the module could be similar to maintenance_sign_oca. Besides, it seems that what is commented in #91 (comment) will also be necessary, right?

yes, it's better to have it in a separate module, I wish I could as I have to patch some js methods.

@etobella
Copy link
Member

etobella commented Apr 3, 2025

We will check the hooks and add them if they have sense. Do not worry about that.

However, I think we shouldn't add unnecessary dependancies on the module.

@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch 3 times, most recently from 61e9209 to da313c8 Compare April 3, 2025 23:11
@kobros-tech
Copy link
Contributor Author

Now I add a standalone module to connect between sing_oca and survey.

@kobros-tech
Copy link
Contributor Author

@dnplkndll

@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch 2 times, most recently from 7e1e4f1 to 0296783 Compare April 4, 2025 05:23
@kobros-tech kobros-tech changed the title [16.0][IMP] sign_oca: connect sign requests with survey answers [ADD] survey_sign_oca: survey and sign_oca connector Apr 4, 2025
@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from 0296783 to 38ad02c Compare April 4, 2025 23:55
@kobros-tech
Copy link
Contributor Author

If there is a signatur field in the request it will throw error, and it is handle in this PR #102 it is inside sign_oca module.

@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from bdd58a7 to 41f289c Compare April 6, 2025 06:08
@kobros-tech
Copy link
Contributor Author

Screenshot from 2025-04-06 08-50-34

Screenshot from 2025-04-06 08-50-49

@kobros-tech
Copy link
Contributor Author

@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch 2 times, most recently from 4a518a0 to 248dbea Compare April 11, 2025 14:23
@kobros-tech
Copy link
Contributor Author

@victoralmau
for the #91 (comment) commit if you are not going to merge, I really need the field_type to be shown in the form view and allow users to deal with. because if someone delete the data I introduce they can not create it again!.

@kobros-tech
Copy link
Contributor Author

@etobella
@victoralmau

I removed the dependency from manifest, but still having the external ones. The one related to survey is not critical here and optional, but the one related to sign_oca is important if getting merged otherwise I show the field I want here instead.

Some handy comments are added to, changes are in a separate commit for simplicity for now.

once you agree we transition to test cases.

@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from 44c8d5f to 908ca86 Compare April 21, 2025 21:29
@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from 908ca86 to 5484dcd Compare April 28, 2025 14:39
@kobros-tech kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from bd0c1b6 to 15cc682 Compare June 16, 2025 10:49
@kobros-tech
Copy link
Contributor Author

@kobros-tech
Copy link
Contributor Author

@victoralmau

Is there anymore comments?

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

<field name="name">res.config.settings.view.form.inherit</field>
<field name="model">res.config.settings</field>
<field name="priority" eval="93" />
<field name="inherit_id" ref="base.res_config_settings_view_form" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper thing to do would be to use the Survey > Settings option which does not exist, using a new block I think is not the most appropriate, IMO there are 2 possible options:

A- Add those fields to Sign > General settings, inheriting from sign_oca.res_config_settings_view_form.
B- Create a base_survey_config module similar to https://github.com/OCA/maintenance/tree/16.0/base_maintenance_config to add a Survey > Settings menu and have this module depend on the other one.

I think the easiest option in this case is option A.

@kobros-tech
Copy link
Contributor Author

@etobella
@victoralmau

how about this module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants