-
-
Notifications
You must be signed in to change notification settings - Fork 59
[ADD] survey_sign_oca: survey and sign_oca connector #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
|
Hi @etobella, |
b1607ee to
cc24057
Compare
|
@kobros-tech I think you want to make a new module for this connector. I think there needs to be a complete process review too. if the fields are to map from the sign to the survey should that be able to be created from the sign template? maybe we could use the US streamlines as a demo item since it covers the most US states and would be able to then create the exemption needed for the tex service. |
cc24057 to
8c7d389
Compare
now I improved the field item to be just one "Survey" and according to each one of them I compare the placehloder to the key of the answer, video is showing that. I didn't want to give my suggestion of creating a new module untill you give me the suggetion on it. I will try to apply other ones too. |
etobella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a glue module. do not add the dependancy here
victoralmau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to #99 (review), I believe the module could be similar to maintenance_sign_oca. Besides, it seems that what is commented in #91 (comment) will also be necessary, right?
yes, it's better to have it in a separate module, I wish I could as I have to patch some js methods. |
|
We will check the hooks and add them if they have sense. Do not worry about that. However, I think we shouldn't add unnecessary dependancies on the module. |
61e9209 to
da313c8
Compare
|
Now I add a standalone module to connect between sing_oca and survey. |
7e1e4f1 to
0296783
Compare
0296783 to
38ad02c
Compare
|
If there is a signatur field in the request it will throw error, and it is handle in this PR #102 it is inside sign_oca module. |
bdd58a7 to
41f289c
Compare
4a518a0 to
248dbea
Compare
|
@victoralmau |
|
I removed the dependency from manifest, but still having the external ones. The one related to survey is not critical here and optional, but the one related to sign_oca is important if getting merged otherwise I show the field I want here instead. Some handy comments are added to, changes are in a separate commit for simplicity for now. once you agree we transition to test cases. |
44c8d5f to
908ca86
Compare
908ca86 to
5484dcd
Compare
bd0c1b6 to
15cc682
Compare
|
Is there anymore comments? |
victoralmau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review OK
| <field name="name">res.config.settings.view.form.inherit</field> | ||
| <field name="model">res.config.settings</field> | ||
| <field name="priority" eval="93" /> | ||
| <field name="inherit_id" ref="base.res_config_settings_view_form" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proper thing to do would be to use the Survey > Settings option which does not exist, using a new block I think is not the most appropriate, IMO there are 2 possible options:
A- Add those fields to Sign > General settings, inheriting from sign_oca.res_config_settings_view_form.
B- Create a base_survey_config module similar to https://github.com/OCA/maintenance/tree/16.0/base_maintenance_config to add a Survey > Settings menu and have this module depend on the other one.
I think the easiest option in this case is option A.
|
how about this module? |


Because of the nice odoo survey interaction and organized questions and well designed format, there is a need to show the signers a survey and fill, then send them a filled sign request waiting for their approval so that we save time for them and fetch information in an interesting way not a boring one.
The commit is under development and we need to apply the idea in a professional way, and business bearing one!
description, configuration is TODO
based on PR
#91
#102
https://github.com/OCA/survey/#157