-
-
Notifications
You must be signed in to change notification settings - Fork 128
[16.0][ADD] survey_previous_page_skip_validation #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] survey_previous_page_skip_validation #185
Conversation
|
please ping me when failing test is fixed |
4b3a44d to
0dc6f4e
Compare
jorgeglez1990
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, functionally tested.
0dc6f4e to
a257b45
Compare
a257b45 to
4d9565f
Compare
edescalona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adasatorres , thanks for your work. Perhaps you could fix the test failure by making its validation configurable? I tested it in a development environment, and I don't get that test error. Otherwise, everything is fine.
LGTM
|
Good morning @edescalona, the error in the tests is from another addon, it has nothing to do with this one. |
|
Hi @adasatorres ok, great job. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Good morning, this addon enables users to navigate back to the previous page in a survey, even if mandatory questions on the current page have not been answered.