Small code adjustment when reading the code

[GitPaean]

hopefully helping the readability.

[GitPaean]

jenkins build this please

[GitPaean]

jenkins build this please

[hakonhagland]

This is a dummy argument for production groups, right? It can be debated if it is more readable to indicate that in the comment or not. I think the original version is more readable here.

[GitPaean]

okay, fair enough. no strong opinion either. I can revert this one.

[GitPaean]

actually I get a warning with my IDE editor because of the comment different from the function declaration.

I changed it to the following way,

        const int num_gr_ctrl = this->groupControlledWells(chain[ii],
                                                           /*always_included_child=*/"",
                                                           /*is_production_group=*/true,
                                                           /*injection_phase=*/Phase::OIL/*not used*/);

[hakonhagland]

Why do we want to change is_producer to is_production_group here? I think both are readable, so no strong opinion.

[GitPaean]

Just trying to be the same with the function declaration, and other usages in the same file.

    int groupControlledWells(const std::string& group_name,
                             const std::string& always_included_child,
                             const bool is_production_group,
                             const Phase injection_phase) const;

[GitPaean]

jenkins build this please

[GitPaean]

Thanks for the review and approval. The firs commit is good to me since there is no loop with the OR operation, it should not be there for the sake of the readability. The second commit is mostly due to not updating the comments when the function declaration was adjusted.

[GitPaean]

With jenkins passes, I am getting the PR in now.