Skip to content

Fix BIOEFFECTS Output Units #6641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

Fix BIOEFFECTS Output Units #6641

merged 1 commit into from
Dec 2, 2025
+5 −5

Conversation

@daavid00
Copy link
Member

@daavid00 daavid00 commented Nov 28, 2025

Following #6640

@daavid00 daavid00 added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Nov 28, 2025
@daavid00
Copy link
Member Author

daavid00 commented Nov 28, 2025

jenkins build this please

@GitPaean
Copy link
Member

GitPaean commented Nov 28, 2025

how about cFoam_, are you familiar with it?

addEntry(baseSolutionVector, "FOAM", UnitSystem::measure::identity, cFoam_); also looks suspicious, likely should be foamdensity, which does not exist yet.

Originally posted by @GitPaean in #6635

@bska
Copy link
Member

bska commented Nov 28, 2025

how about cFoam_, are you familiar with it?

I'm working on that.

@GitPaean
Copy link
Member

GitPaean commented Nov 28, 2025

how about the definition of cCalcite_ and cBiofilm_. they are fractions?

@daavid00
Copy link
Member Author

daavid00 commented Nov 28, 2025

how about the definition of cCalcite_ and cBiofilm_. they are fractions?

Yes, volume fractions, so the unit is identity.

@bska
Copy link
Member

bska commented Nov 28, 2025

how about cFoam_, are you familiar with it?

I'm working on that.

Please see PR #6643.

@GitPaean GitPaean requested a review from totto82 November 28, 2025 15:35
@totto82 totto82 merged commit 330bfc0 into OPM:master Dec 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@totto82 totto82 Awaiting requested review from totto82

Assignees

No one assigned

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daavid00 @GitPaean @bska @totto82