Skip to content

Reduce number of temps files and size in temp files test #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anayrat wants to merge 1 commit into from
Closed

Reduce number of temps files and size in temp files test #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ jobs:
- name: Execute all tests
run: PATH="/usr/lib/postgresql/${{ matrix.pg }}/bin/:$PATH" prove
- name: print logs if test failed
run: cat tmp_check/log/*
run: grep "" tmp_check/log/*
if: ${{ failure() }}
143 changes: 72 additions & 71 deletions t/01-temp-files.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ my $t0; # use to avoid two check_pga calls within the same second.
# See comment before first call of usleep.

$node->init;
$node->append_conf('postgresql.conf', 'work_mem=64kB');
$node->start;

### Beginning of tests ###
Expand Down Expand Up @@ -56,7 +57,7 @@ SKIP: {
0,
[ qr/^Service *: POSTGRES_TEMP_FILES$/m,
qr/^Returns *: 0 \(OK\)$/m,
qr/^Message *: [2-3] tablespace\(s\)\/database\(s\) checked$/m,
qr/^Message *: [2-4] tablespace\(s\)\/database\(s\) checked$/m,
],
[ qr/^$/ ],
'basic check'
Expand All @@ -65,8 +66,8 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file count => Returns OK
# The query generates between 17.5MB (9.4) and 11,7MB (14) of WAL
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
# Generate one temp file of 140000 bytes
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

# The added sleep ensures that two tests are not executed within the same
# seconds.
Expand All @@ -92,10 +93,10 @@ SKIP: {
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files warn=3 crit=4$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files warn=3 crit=4$/m,
qr/^Perfdata *: template1=0B$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files warn=3 crit=4$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B$/m,
],
[ qr/^$/ ],
'test file count OK'
Expand All @@ -104,15 +105,15 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file count => Returns WARN
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

usleep(100_000) while tv_interval($t0) < 1.01;
$node->command_checks_all( [
'./check_pgactivity', '--service' => 'temp_files',
'--username' => $ENV{'USER'} || 'postgres',
'--format' => 'human',
'--dbname' => 'template1',
'--warning' => '1',
'--warning' => '0',
'--critical' => '3'
],
1,
Expand All @@ -121,12 +122,12 @@ SKIP: {
qr/^Message *: postgres \(.* file\(s\)\/.*\)$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files warn=1 crit=3$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files warn=0 crit=3$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files warn=1 crit=3$/m,
qr/^Perfdata *: template1=0B$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files warn=0 crit=3$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B$/m,
],
[ qr/^$/ ],
'test file count WARN'
Expand All @@ -135,7 +136,7 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file count => Returns CRIT
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

usleep(100_000) while tv_interval($t0) < 1.01;
$node->command_checks_all( [
Expand All @@ -144,20 +145,20 @@ SKIP: {
'--format' => 'human',
'--dbname' => 'template1',
'--warning' => '0',
'--critical' => '1'
'--critical' => '0'
],
2,
[ qr/^Service *: POSTGRES_TEMP_FILES$/m,
qr/^Returns *: 2 \(CRITICAL\)$/m,
qr/^Message *: postgres \(.* file\(s\)\/.*\)$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files warn=0 crit=1$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files warn=0 crit=0$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files warn=0 crit=1$/m,
qr/^Perfdata *: template1=0B$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files warn=0 crit=0$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B$/m,
],
[ qr/^$/ ],
'test file count CRIT'
Expand All @@ -166,16 +167,16 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file size => Returns OK
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

usleep(100_000) while tv_interval($t0) < 1.01;
$node->command_checks_all( [
'./check_pgactivity', '--service' => 'temp_files',
'--username' => $ENV{'USER'} || 'postgres',
'--format' => 'human',
'--dbname' => 'template1',
'--warning' => '40MB',
'--critical' => '50MB'
'--warning' => '200kB',
'--critical' => '300kB'
],
0,
[ qr/^Service *: POSTGRES_TEMP_FILES$/m,
Expand All @@ -184,11 +185,11 @@ SKIP: {
qr/^Perfdata *: postgres=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=40MB crit=50MB$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files$/m,
qr/^Perfdata *: template1=0B warn=40MB crit=50MB$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=200kB crit=300kB$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B warn=200kB crit=300kB$/m,
],
[ qr/^$/ ],
'test file size OK'
Expand All @@ -197,16 +198,16 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file size => Returns WARN
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

usleep(100_000) while tv_interval($t0) < 1.01;
$node->command_checks_all( [
'./check_pgactivity', '--service' => 'temp_files',
'--username' => $ENV{'USER'} || 'postgres',
'--format' => 'human',
'--dbname' => 'template1',
'--warning' => '4MB',
'--critical' => '40MB'
'--warning' => '100kB',
'--critical' => '200kB'
],
1,
[ qr/^Service *: POSTGRES_TEMP_FILES$/m,
Expand All @@ -215,11 +216,11 @@ SKIP: {
qr/^Perfdata *: postgres=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=4MB crit=40MB$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files$/m,
qr/^Perfdata *: template1=0B warn=4MB crit=40MB$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=100kB crit=200kB$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B warn=100kB crit=200kB$/m,
],
[ qr/^$/ ],
'test file size WARN'
Expand All @@ -228,16 +229,16 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file size => Returns CRIT
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

usleep(100_000) while tv_interval($t0) < 1.01;
$node->command_checks_all( [
'./check_pgactivity', '--service' => 'temp_files',
'--username' => $ENV{'USER'} || 'postgres',
'--format' => 'human',
'--dbname' => 'template1',
'--warning' => '4MB',
'--critical' => '5MB'
'--warning' => '50kB',
'--critical' => '100kB'
],
2,
[ qr/^Service *: POSTGRES_TEMP_FILES$/m,
Expand All @@ -246,11 +247,11 @@ SKIP: {
qr/^Perfdata *: postgres=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=4MB crit=5MB$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files$/m,
qr/^Perfdata *: template1=0B warn=4MB crit=5MB$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=50kB crit=100kB$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B warn=50kB crit=100kB$/m,
],
[ qr/^$/ ],
'test file count CRIT'
Expand All @@ -259,7 +260,7 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file size and count => Returns OK
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

usleep(100_000) while tv_interval($t0) < 1.01;
$node->command_checks_all( [
Expand All @@ -278,10 +279,10 @@ SKIP: {
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files warn=3 crit=4$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=48.102MB crit=64.102MB$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files warn=3 crit=4$/m,
qr/^Perfdata *: template1=0B warn=48.102MB crit=64.102MB$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files warn=3 crit=4$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B warn=48.102MB crit=64.102MB$/m,
],
[ qr/^$/ ],
'test file size and count OK '
Expand All @@ -290,16 +291,16 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file size and count => Returns WARN
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

usleep(100_000) while tv_interval($t0) < 1.01;
$node->command_checks_all( [
'./check_pgactivity', '--service' => 'temp_files',
'--username' => $ENV{'USER'} || 'postgres',
'--format' => 'human',
'--dbname' => 'template1',
'--warning' => '1,16486kB',
'--critical' => '3,49254kB'
'--warning' => '1,100kB',
'--critical' => '3,200kB'
],
1,
[ qr/^Service *: POSTGRES_TEMP_FILES$/m,
Expand All @@ -308,11 +309,11 @@ SKIP: {
qr/^Perfdata *: postgres=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files warn=1 crit=3$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=16.102MB crit=48.102MB$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files warn=1 crit=3$/m,
qr/^Perfdata *: template1=0B warn=16.102MB crit=48.102MB$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=100kB crit=200kB$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files warn=1 crit=3$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B warn=100kB crit=200kB$/m,
],
[ qr/^$/ ],
'test file size and count WARN'
Expand All @@ -321,16 +322,16 @@ SKIP: {
$t0 = [gettimeofday];

# unit test based on the file size and count => Returns CRIT
$node->psql('postgres', 'SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;');
$node->psql('postgres', 'SELECT count(*) FROM generate_series(1,10000);');

usleep(100_000) while tv_interval($t0) < 1.01;
$node->command_checks_all( [
'./check_pgactivity', '--service' => 'temp_files',
'--username' => $ENV{'USER'} || 'postgres',
'--format' => 'human',
'--dbname' => 'template1',
'--warning' => '0,0MB',
'--critical' => '1,4MB'
'--warning' => '0,50kB',
'--critical' => '1,100kB'
],
2,
[ qr/^Service *: POSTGRES_TEMP_FILES$/m,
Expand All @@ -339,11 +340,11 @@ SKIP: {
qr/^Perfdata *: postgres=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files warn=0 crit=1$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=0B crit=4MB$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files warn=0 crit=1$/m,
qr/^Perfdata *: template1=0B warn=0B crit=4MB$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B warn=50kB crit=100kB$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files warn=0 crit=1$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B warn=50kB crit=100kB$/m,
],
[ qr/^$/ ],
'test file size and count CRIT'
Expand Down Expand Up @@ -384,7 +385,7 @@ SKIP: {

$node->psql('postgres', q{
SET temp_tablespaces TO myts2;
SELECT count(*) FROM (SELECT random() * x FROM generate_series(1,1000000) AS F(x) ORDER BY 1) q;
SELECT count(*) FROM generate_series(1,10000) ;
});

ok(-f "$tbsp2_tmp/pgsql_tmp1.1", "temp file pgsql_tmp1.1 exists in tablespace myts2");
Expand All @@ -409,10 +410,10 @@ SKIP: {
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: postgres=[1-9][0-9]*Files$/m,
qr/^Perfdata *: postgres=[1-9][.0-9]*[kMGTPE]*B$/m,
qr/^Perfdata *: template1=0Fpm$/m,
qr/^Perfdata *: template1=0Bpm$/m,
qr/^Perfdata *: template1=0Files$/m,
qr/^Perfdata *: template1=0B$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*Fpm$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*Bpm$/m,
qr/^Perfdata *: template1=[1-9][0-9]*Files$/m,
qr/^Perfdata *: template1=[1-9][.0-9]*[kMGTPE]*B$/m,
],
[ qr/^$/ ],
'test with a tablespace'
Expand Down