-
Notifications
You must be signed in to change notification settings - Fork 16
Austin token encryption #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoshuaSBrown
wants to merge
716
commits into
devel
Choose a base branch
from
Austin-TokenEncryption
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Austin token encryption #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollection-endpoint-browse Revert "[DLT-1110] Mapped Collection Endpoint Browse (1/4)"
1209 feature add jsdoc linter
Co-authored-by: Anthony Ramirez <ramirezat@ornl.gov>
…p-script Throw error if OpenStack error code returned from API
[DAPS, Foxx] - 1180 refactor Part 2 authz
* Add conditional switch and stub some logic for handling other resources in callbacks * Fix order of logging. Add redirect * Debug logging for web service. Attempt to set token. * Remove incorrect method call to data, use data attribute. * Add some TODOs and logging * Give setAccessToken ability to accept additional params to pass to protobuf * Add additional params to DatabaseAPI::userSetAccessToken to pass message with addtional info on to database API. * Add convenience method with old type signature of DatabaseAPI::userSetAccessToken for compatibility * Conditionally add other token options param when calling dbGetRaw. * Pass token type along to Database API. * Pass token type from message. * Stub logic for updating related edge in router function for token/set * Include logic for conditionally updating token data and pushing data to edge. * Change token_key to remove illegal characters * Fix object attribute call * Prettier formatting for datafed-ws.js * Roll back changes to DatabaseAPI.hpp and DatabaseAPI.cpp that are covered in #1127 * Refactor new inclusions in datafed-ws.js to use as much existing code as possible, only diverge where necessary. * datafed-ws.js change scopes to scope * datafed-ws.js log user ID array * datafed-ws.js clarify uid assignment at ui/authn endpoint, add note on error cases, remove incorrect comment about uid, add appropriate error if collection_id not present * datafed-ws.js Extract AccessTokenType enum, add comment about fetching from protobuf; remove unnecessary commented code * datafed-ws.js Extract transfer set logic when calling setAccessToken to improve readability of router. * datafed-ws.js Create function for resolving token type; create function to handle logic in building optional_data for setAccessToken; reduce unneccessary nesting in ui/authn endpoint * datafed-ws.js Fix spacing, fix typo in variable name * datafed-ws.js Fix bug referring to request session * datafed-ws.js Nesting was necessary. * datafed-ws.js Address some TODOs, set token type with more context * datafed-ws.js Remove some additional extraneous logging * datafed-ws.js Formatting * Add comment about token set * datafed-ws.js Update deprecated substring method, Fix order for error case when new user receives transfer token * TokenHandler.js Refactor token handling logic out of web server main. datafed-ws.js User new OAuthTokenHandler class to handle token logic. * TokenHandler.js Implement token validator; move OAuthTransferToken def to top. TokenHandler.test.js Minimal testing of token handler * TokenHandler.test.js Add tests for case when resource server is auth * TokenHandler.test.js Add testing for Globus transfer resource server * TokenHandler.js Implement validation for existence of required keys. TokenHandler.test.js Adjust other_tokens fixtures to be nested according to incoming data; formatting. * datafed-ws.js formatting * TokenHandler.js Update error messages, remove unnecessary code in getTokenType, returns in resolveTokenType * datafed-ws.js Add error handling around token_handler construction; add errors and handling for setAccessToken, JSDoc. * datafed-ws.js Remove hard coded collection_id. * datafed-ws.js Remove thrown errors in nested functions; single redirect. --------- Co-authored-by: Anthony Ramirez <ramirezat@ornl.gov>
* datafed-ws.js Reverse order of LogLevel object properties * datafed-ws.js Throw error so stack trace is adequately populated * Revert line number * TokenHandler.js Fix linting errors. --------- Co-authored-by: Anthony Ramirez <ramirezat@ornl.gov>
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
JoshuaSBrown
commented
Aug 12, 2025
| fi | ||
| docker build -f \ | ||
| "${PROJECT_ROOT}/core/docker/Dockerfile" \ | ||
| "${PROJECT_ROOT}/core/docker/Dockerfile" --no-cache \ |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| "${PROJECT_ROOT}/core/docker/Dockerfile" --no-cache \ | |
| "${PROJECT_ROOT}/core/docker/Dockerfile" \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Core
Relates to core service
Priority: High
Highest priority
Type: New Feature
New or enhanced feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Tasks
Summary by Sourcery
Implement AES-256-CBC token encryption support and integrate it across the system
New Features:
Enhancements:
Build:
Tests:
Chores: