[DAPS-1517] Add Handling to CPP Core Service #1603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for authz lookup
…80-refactor-authz
…80-refactor-authz
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…scanning 1216 daps feature add improved ci scanning
AronPerez
force-pushed
the
feat-DAPS-1516-default-repo-type
branch
from
120b760 to
ef7a67d
Compare
This reverts commit c5c2874. Revert "[DAPS-1531] Update comments" This reverts commit 464b0f1. Revert "[DAPS-1531] Address CI" This reverts commit 4d66b75. Revert "[DAPS-1531] Object to object" This reverts commit 5c39a8d. Revert "[DAPS-1531] Address Object -> object, address copilot comments" This reverts commit ae39a84.
… Rust-Compatible js
…e test if unsupported - Added tests for `repoCreate` with explicit `type='globus'` and `type='metadata_only'`. - Verified default type behavior when no type is specified (`defaults to 'globus'`). - Tested updating repository type via `repoUpdate`. - Ensured all tests validate type field presence and correct values. - Skipped `repoUpdate` test if the method is unavailable in the Python SDK.
* [DAPS-1519] Update SDK, add tests * [DAPS-1519] Address Sourcery AI feedback * [DAPS-1519] Update param name, simplify tests
AronPerez
force-pushed
the
feat-DAPS-1517-cpp-core-svc-handling
branch
from
d036aa3 to
bf30325
Compare
Collaborator
|
@AronPerez are you wanting to finish this feature? There is of course no pressure to do so other than if you are it still needs to get done within the timeline. Otherwise, I will be reassigning these items to myself. |
Contributor
Author
|
Sure. There's currently a bug with the core service not receiving the request for allocation creation with the added type to give you an idea of where I'm at with that |
Collaborator
Just to be clear that's a yes, you do want to wrap it up. |
Collaborator
|
I am assigning all of these items to myself. |
JoshuaSBrown
changed the base branch from
feat-DAPS-1516-default-repo-type
to
devel
JoshuaSBrown
added a commit
that referenced
this pull request
Oct 14, 2025
…data (#1603) Co-authored-by: Aaron Perez <perezam@ornl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DAPS-1517
Description
This PR implements a new repository
typefield with two supported values:"globus"(default, for traditional repositories) and"metadata_only"(for metadata-only repositories).Implementation Details
Protocol Buffer Changes
optional string type = 12to RepoData messageoptional string type = 13to RepoCreateRequest and RepoUpdateRequestC++ Core Service (DatabaseAPI.cpp)
How Has This Been Tested?
core/database/foxx/tests/operations.test.js&core/database/foxx/tests/repo.test.jstests/end-to-end/test_api_repo.pySummary by Sourcery
Add handling for the repository type field in the core service, update the DatabaseAPI client to pass and parse the type, and cover the new behavior with end-to-end tests.
New Features:
Enhancements:
Tests: