Update: native client id in intialize_globus_endpoint and globus_clea…

[JoshuaSBrown]

…nup files updated.

Ticket

 

Description

How Has This Been Tested?

Artifacts (if appropriate):

Tasks

• - A description of the PR has been provided, and a diagram included if it is a new feature.
• - Formatter has been run
• - CHANGELOG comment has been added
• - Labels have been assigned to the pr
• - A reviwer has been added
• - A user has been assigned to work on the pr
• - If new feature a unit test has been added

Summary by Sourcery

Enhancements:

• Replace the hard-coded CLIENT_ID constant with a new native Globus client ID in globus_cleanup.py and initialize_globus_endpoint.py

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the hardcoded Native Client ID used by the Globus setup scripts to a new GUID.

Class diagram for updated CLIENT_ID constant in Globus scripts

classDiagram
    class globus_cleanup {
        +CLIENT_ID : str = "d7a7db79-c746-4947-9273-54cf578e4785"
    }
    class initialize_globus_endpoint {
        +CLIENT_ID : str = "d7a7db79-c746-4947-9273-54cf578e4785"
    }

Loading

File-Level Changes

Change	Details	Files
Update Native Client ID constant for DataFed Globus scripts	Replaced CLIENT_ID value in globus_cleanup.py Replaced CLIENT_ID value in initialize_globus_endpoint.py	scripts/globus/globus_cleanup.py scripts/globus/initialize_globus_endpoint.py

Possibly linked issues

• #[Update] - Invalid Native Client ID: The PR updates the Globus native client ID in initialize_globus_endpoint.py and globus_cleanup.py which directly resolves the invalid client ID issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[JoshuaSBrown]

This is failing because the globus_sdk changed, and the sdk version numbers are not pinned.

code: success
When creating a guest collection it must be created in: /mnt/datafed
And the display name should be exactly: DataFedCI Collection Guest
You will also need to add permissions for all Globus users so that they have write access.

When registering the repository with DataFed the ID must be: datafedci-home
When registering the repository with DataFed path is abs to the mapped collection and must be listed as: /mnt/datafed/datafedci-home
Traceback (most recent call last):
  File "/datafed/source/scripts/globus/create_guest_collection.py", line 85, in <module>
    token_response = confidential_client.oauth2_client_credentials_tokens()
TypeError: oauth2_client_credentials_tokens() missing 1 required positional argument: 'requested_scopes'