Initial implementation of generic phasor dynamics app#359
Draft
PhilipFackler wants to merge 2 commits intodevelopfrom
Draft
Initial implementation of generic phasor dynamics app#359PhilipFackler wants to merge 2 commits intodevelopfrom
PhilipFackler wants to merge 2 commits intodevelopfrom
Conversation
…test with ThreeBusBasic case
pelesh
requested changes
Apr 6, 2026
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
Looks good as is. A couple of things to address before we merge:
- Please add a README file explaining solver configuration input. A skeletal document is sufficient as I expect @abirchfield will want to add more features to that.
- Please make sure CI tests pass (see comment below).
| @@ -0,0 +1 @@ | |||
| add_subdirectory(PhasorDynamics) | |||
Collaborator
There was a problem hiding this comment.
The GridKit code should build without SUNDIALS. Consider adding this guard to prevent failing CI tests:
Suggested change
| add_subdirectory(PhasorDynamics) | |
| if(TARGET SUNDIALS::idas) | |
| add_subdirectory(PhasorDynamics) | |
| endif() |
| WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) | ||
|
|
||
| add_test(NAME ThreeBusBasic_using_app | ||
| COMMAND PDSim ${CMAKE_CURRENT_SOURCE_DIR}/ThreeBusBasic.study.json |
Collaborator
There was a problem hiding this comment.
Perhaps call it solver or config?
Suggested change
| COMMAND PDSim ${CMAKE_CURRENT_SOURCE_DIR}/ThreeBusBasic.study.json | |
| COMMAND PDSim ${CMAKE_CURRENT_SOURCE_DIR}/ThreeBusBasic.solver.json |
Similarly, we could rename ThreeBusBasic.json --> ThreeBusBasic.case.json to be more self-explanatory to the domain folk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please describe the issue that is addressed (bug, new feature,
documentation, enhancement, etc.). Please also include relevant motivation and
context. List any dependencies that are required for this change.
See #349
Proposed changes
Describe how your changes here address the issue and why the proposed changes
should be accepted.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining
why you chose the solution you did and what alternatives you considered, etc...