Skip to content

Conversation

@echoix
Copy link
Member

@echoix echoix commented Nov 2, 2025

Ruff rule: https://docs.astral.sh/ruff/rules/unused-variable/

Only a few remaining cases were present.
Either removed the assignment, or used it. For example, in the r.terraflow test, committed a few years back by @ninsbl in #265, a r.univar result existed but was never used. Using it here. Worked on Linux, waiting to see if other platforms work too.

@echoix echoix requested a review from ninsbl November 2, 2025 22:27
@github-actions github-actions bot added CI Continuous integration vector Related to vector data processing raster Related to raster data processing temporal Related to temporal data processing Python Related code is in Python libraries module tests Related to Test Suite labels Nov 2, 2025
@echoix echoix merged commit 072a1ce into OSGeo:main Nov 3, 2025
30 of 32 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Nov 3, 2025
@echoix echoix deleted the ruff-F841-unused-var branch November 6, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration libraries module Python Related code is in Python raster Related to raster data processing temporal Related to temporal data processing tests Related to Test Suite vector Related to vector data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants