CQ: Fix PTH112: os.path.isdir() should be replaced by Path.is_dir()
#6603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
GUI
ninsbl
reviewed
Nov 11, 2025
Member
ninsbl
left a comment
ninsbl
left a comment
There was a problem hiding this comment.
Few cases where join is not needed.
The whole get_lib_path function could be simplified by using Path throughout, but that is a different issue....
Co-authored-by: Stefan Blumentrath <stefan.blumentrath@gmx.de>
Member
Author
|
@ninsbl is the isdir places you highlighted fixed in here? Otherwise the conflicts are solved and no other rule violations once together |
ninsbl
approved these changes
Nov 12, 2025
Member
ninsbl
left a comment
ninsbl
left a comment
There was a problem hiding this comment.
There is in unnecessary join left, but since os.path.join has to be tackled later anyway, I think is is OK to merge. Feel free to disregard this occurrence...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff rule: https://docs.astral.sh/ruff/rules/os-path-isdir/
Continues on #6573