wxGUI/gmodeler: Correct variable replacement in model_convert.py#7241
Open
gureckyfrantisek wants to merge 1 commit intoOSGeo:mainfrom
Open
wxGUI/gmodeler: Correct variable replacement in model_convert.py#7241gureckyfrantisek wants to merge 1 commit intoOSGeo:mainfrom
gureckyfrantisek wants to merge 1 commit intoOSGeo:mainfrom
Conversation
gureckyfrantisek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the issue which caused the previous variable in the same string not get recognized.
The issue was that when another match was found, the old value got replaced instead of the updated one called "parametrizedValue".
Also made the curly braces around variable names optional, they get recognized correctly but leaving them mandatory should be readable, that is up for debate.
I tested this with r.in.pdal and a *.laz file and the import worked as expected with both the values replaced with options.
This will resolve #7212.