Skip to content

Fix assertion error in lmm_add_free (e.g. when block=0x2345, size=2) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lxylxy123456 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix assertion error in lmm_add_free (e.g. when block=0x2345, size=2) #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b5bf3
Fix assertion error in lmm_add_free (e.g. when block=0x2345, size=2)
lxylxy123456 Dec 21, 2022
725e3c5
Fix typo
lxylxy123456 Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lmm/lmm_add_free.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,9 @@ void lmm_add_free(lmm_t *lmm, void *block, oskit_size_t size)
Here we can assume no such thing. */
min = (min + ALIGN_MASK) & ~ALIGN_MASK;
max &= ~ALIGN_MASK;
assert(max >= min);

/* If after alignment we have nothing left, we're done. */
if (max == min)
if (max <= min)
return;

/* Add the block to the free list(s) of whatever region(s) it overlaps.
Expand Down