feat: allow user to define custom CMSIS version via CMake cache variable#352
Open
ashen1queter wants to merge 2 commits intoObKo:masterfrom
Open
feat: allow user to define custom CMSIS version via CMake cache variable#352ashen1queter wants to merge 2 commits intoObKo:masterfrom
ashen1queter wants to merge 2 commits intoObKo:masterfrom
Conversation
Added support for setting a custom CMSIS version by defining the CMSIS_CUSTOM_VERSION cache variable. This allows users to override the default CMSIS version during CMake configuration by passing: -DCMSIS_CUSTOM_VERSION=<version> If not specified, the script defaults to version v5.6.0
…ectness via CMake cache variable Added support for setting a custom CMSIS version by defining the CMSIS_CUSTOM_VERSION cache variable. This allows users to override the default CMSIS version during CMake configuration by passing: -DCMSIS_CUSTOM_VERSION=<version> Additionally, validation has been added to check if the custom CMSIS version is valid, ensuring that only supported versions are used and a list of valid versions are displayed too. If not specified, the script defaults to version v5.6.0
Hish15
approved these changes
Aug 4, 2025
Collaborator
|
Hi @ashen1queter, It would be nice to add a UT before merging this. Are you willing to do it ? |
Hish15
reviewed
Aug 7, 2025
| if(DEFINED CMSIS_CUSTOM_VERSION AND NOT "${CMSIS_CUSTOM_VERSION}" STREQUAL "") | ||
| list(FIND VALID_CMSIS_VERSIONS " ${CMSIS_CUSTOM_VERSION}" VALID_VERSION_INDEX) | ||
| if(VALID_VERSION_INDEX EQUAL -1) | ||
| message(FATAL_ERROR "Invalid CMSIS version provided ${CMSIS_CUSTOM_VERSION}. Supported versions are: ${VALID_CMSIS_VERSIONS}") |
Collaborator
There was a problem hiding this comment.
I like this, but it does make us follow the releases... Isn't letting the Fetch fail enough ?
What do you think @atsju ?
Collaborator
There was a problem hiding this comment.
Same. Have an explicit error message on how the user can find valid versions when fetch fails (with one or two examples).
But avoid having stm32-cmake to follow CMSIS releases. We have no automation for this.
Author
There was a problem hiding this comment.
I will get back to this, I am currently involved in an internship
ashen1queter
added a commit
to ashen1queter/stm32-cmake
that referenced
this pull request
Jan 10, 2026
ashen1queter
added a commit
to ashen1queter/stm32-cmake
that referenced
this pull request
Jan 10, 2026
ashen1queter
added a commit
to ashen1queter/stm32-cmake
that referenced
this pull request
Jan 10, 2026
ashen1queter
added a commit
to ashen1queter/stm32-cmake
that referenced
this pull request
Jan 10, 2026
ashen1queter
added a commit
to ashen1queter/stm32-cmake
that referenced
this pull request
Jan 10, 2026
ashen1queter
added a commit
to ashen1queter/stm32-cmake
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for setting a custom CMSIS version by defining the CMSIS_CUSTOM_VERSION cache variable. This allows users to override the default CMSIS version during CMake configuration by passing:
-DCMSIS_CUSTOM_VERSION=
If not specified, the script defaults to version v5.6.0