-
Notifications
You must be signed in to change notification settings - Fork 130
*: prepare-minor-full-release gh action #4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new GitHub Actions workflow (tag-minor-full-release.yml) to automate the process of creating a stable minor release from a release candidate branch. The workflow finds the latest main-vX.Y release branch, creates two PRs (one to update the release branch to stable version vX.Y.0 and another to bump main to the next dev version vX.(Y+1)-dev), and creates a stable version tag.
Key Changes:
- Automated discovery of the latest minor release branch matching pattern
main-vX.Y - Automated creation of PRs to update versions in
app/version/version.go - Automated tag creation for the stable release version
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4101 +/- ##
=======================================
Coverage 56.37% 56.37%
=======================================
Files 245 245
Lines 31169 31169
=======================================
+ Hits 17571 17572 +1
- Misses 11284 11287 +3
+ Partials 2314 2310 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Replace v<MAJOR>.<MINOR>-rc with v<MAJOR>.<MINOR>.0 | ||
| sed -i -E "s/^(var version = )\"v${MAJOR}\.${MINOR}-rc\"/\1\"${STABLE_VERSION}\"/" "$VERSION_FILE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do v<MAJOR>.<MINOR> here? We usually stick to only
v<MAJOR>.<MINOR>
v<MAJOR>.<MINOR>-rc
v<MAJOR>.<MINOR>-dev
for this variable.
The patches and specific rcs we do with git tag.
|



Introduces
prepare-minor-full-release.ymlandtag-minor-full-release.ymlGH action.prepare-minor-full-release.ymlfinds the latest release branch (e.g.,main-vX.Ycreated frombump-minor-version.yml#4084), creates a PR to update release branch version fromvX.Y-rctovX.Y.0(stable release), and creates a PR to update main branch version fromvX.Y-devtovX.(Y+1)-dev.tag-minor-full-release.ymlvalidates that the stable version PR has been merged, creates and pushes the tagvX.Y.0, and can auto-detect latest release branch or accept manual input.Workflow: Run
prepare-minor-full-release.ymlto create the PRs, review and merge the stable version PR to the release branch, runtag-minor-full-release.ymlto create and push the tag, then merge the dev version PR to main to start the next development cycle.category: misc
ticket: #3933