Remove Helm aliases and use name instead #2888
Merged
+46
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
reviewed
Oct 27, 2025
| - repoURL: https://github.com/another-repo/values-files-here | ||
| targetRevision: main | ||
| ref: remote-values | ||
| name: ref-source |
There was a problem hiding this comment.
this example won't work as the two values files have a different layout.
There was a problem hiding this comment.
I'll combine the previous path then that should work
argo.octopus.com/image-replace-paths.helm-source: "{{ .Values.image.name}}:{{ .Values.image.version}}, {{ .Values.different.structure.here.image }}"
| argo.octopus.com/image-replace-paths.other-values: "{{ .Values.another-image.name }}" | ||
| argo.octopus.com/image-replace-paths.remote-values: "{{ .Values.image.name}}:{{ .Values.image.version}}" | ||
| argo.octopus.com/image-replace-paths.helm-source: "{{ .Values.another-image.name }}" |
There was a problem hiding this comment.
same problem as previous - the two values files have different content which is not supported.
There was a problem hiding this comment.
Change to
argo.octopus.com/image-replace-paths.helm-source: "{{ .Values.image.name}}:{{ .Values.image.version}}, {{ .Values.another-image.name }}"
Co-authored-by: Trent Mohay <trent.mohay@octopus.com>
Co-authored-by: Trent Mohay <trent.mohay@octopus.com>
Co-authored-by: Trent Mohay <trent.mohay@octopus.com>
Co-authored-by: Trent Mohay <trent.mohay@octopus.com>
… into frank/helmalias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-125060]
Corresponding code change: OctopusDeploy/Calamari#1614