add some frontend concepts for the future #773
Conversation
🤖 Auto-Component Test Results🎉 No new UI components detected!This PR doesn't add any new buttons, menus, or clickable components. Triggered by @Graison-P • Commit |
📝 Mega PR Test SkippedHi @Graison-P! The comprehensive Mega PR test was skipped because this PR only changes documentation or configuration files (.md, .txt, .yml, .yaml). To force the Mega PR test to run, comment |
Summary by CodeRabbit
WalkthroughAdds a new static text resource with UI message templates and updates the static credits HTML to rename and reorganize credit sections and contributor listings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR adds user-facing message templates, but has critical issues that block merge:
Critical Issues:
- Messages reference features that don't exist in OmniBlocks (project sharing system, user accounts, banning system). The README explicitly states there's no Scratch account integration or login system.
Spelling/Grammar Errors:
- Multiple typos in user-facing text that need correction
Recommendation: Clarify which features are being planned and ensure the message concepts align with actual or planned functionality. Fix all spelling errors before merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| "Congrats! You shared your first project!" | ||
| error_01: | ||
| "Oops! That project couldnt be shared. Refresh and try again!" | ||
| error_02: | ||
| "The editor has encountered a internal issue and has crashed. Please check the error on the editor and send a bug reoprt." | ||
| tempbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | ||
| permbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you belive this is a mistake, please contact us." |
There was a problem hiding this comment.
🛑 Logic Error: This file references user account features (sharing projects, banning) that contradict OmniBlocks' architecture. According to the project README, OmniBlocks has NO Scratch account integration and no login system. Features like project sharing to a community platform and user banning cannot function without an authentication system. These messages reference non-existent functionality.
There was a problem hiding this comment.
@Amazon-Q-Developer This is based off not scratch but the fact OmniBlocks has its own account system
❌ ULTRA Visual Regression Testing - Tests FailedHi @Graison-P! The test matrix failed to produce any results. All 9 test combinations failed. This could be due to:
Please check the logs for details: The build phase completed successfully, but the test execution failed. |
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new static text resource containing draft (“concept”) user-facing frontend messages intended for future UI surfaces in OmniBlocks.
Changes:
- Added
static/futurefrontend/pagestextconcepts.txtwith keyed message templates (welcome, first project, error, ban messages).
| first_proj: | ||
| "Congrats! You shared your first project!" | ||
| error_01: | ||
| Oops! That project couldn't be shared. Refresh and try again! |
There was a problem hiding this comment.
User-facing string typo: "couldnt" should be "couldn't".
| Oops! That project couldn't be shared. Refresh and try again! | |
| "Oops! That project couldn't be shared. Refresh and try again!" |
| error_01: | ||
| Oops! That project couldn't be shared. Refresh and try again! | ||
| error_02: | ||
| "The editor has encountered a internal issue and has crashed. Please check the error on the editor and send a bug reoprt." |
There was a problem hiding this comment.
User-facing string grammar: "a internal" should be "an internal".
| "The editor has encountered a internal issue and has crashed. Please check the error on the editor and send a bug reoprt." | |
| "The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug reoprt." |
| error_01: | ||
| Oops! That project couldn't be shared. Refresh and try again! | ||
| error_02: | ||
| "The editor has encountered a internal issue and has crashed. Please check the error on the editor and send a bug reoprt." |
There was a problem hiding this comment.
User-facing string typo: "reoprt" should be "report".
| "The editor has encountered a internal issue and has crashed. Please check the error on the editor and send a bug reoprt." | |
| "The editor has encountered a internal issue and has crashed. Please check the error on the editor and send a bug report." |
| tempbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | ||
| permbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you belive this is a mistake, please contact us." |
There was a problem hiding this comment.
User-facing string typo: "belive" should be "believe".
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you belive this is a mistake, please contact us." | |
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us." |
🤖 Auto-Component Test Results🎉 No new UI components detected!This PR doesn't add any new buttons, menus, or clickable components. Triggered by @Graison-P • Commit |
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
📝 Mega PR Test SkippedHi @Graison-P! The comprehensive Mega PR test was skipped because this PR only changes documentation or configuration files (.md, .txt, .yml, .yaml). To force the Mega PR test to run, comment |
🤖 Auto-Component Test Results🎉 No new UI components detected!This PR doesn't add any new buttons, menus, or clickable components. Triggered by @Graison-P • Commit |
📝 Mega PR Test SkippedHi @Graison-P! The comprehensive Mega PR test was skipped because this PR only changes documentation or configuration files (.md, .txt, .yml, .yaml). To force the Mega PR test to run, comment |
❌ ULTRA Visual Regression Testing - Tests FailedHi @Graison-P! The test matrix failed to produce any results. All 9 test combinations failed. This could be due to:
Please check the logs for details: The build phase completed successfully, but the test execution failed. |
Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
🤖 Auto-Component Test Results🎉 No new UI components detected!This PR doesn't add any new buttons, menus, or clickable components. Triggered by @Graison-P • Commit |
📝 Mega PR Test SkippedHi @Graison-P! The comprehensive Mega PR test was skipped because this PR only changes documentation or configuration files (.md, .txt, .yml, .yaml). To force the Mega PR test to run, comment |
❌ ULTRA Visual Regression Testing - Tests FailedHi @Graison-P! The test matrix failed to produce any results. All 9 test combinations failed. This could be due to:
Please check the logs for details: The build phase completed successfully, but the test execution failed. |
❌ ULTRA Visual Regression Testing - Tests FailedHi @Graison-P! The test matrix failed to produce any results. All 9 test combinations failed. This could be due to:
Please check the logs for details: The build phase completed successfully, but the test execution failed. |
| "Hello, {USERNAME}! Welcome to OmniBlocks!" | ||
| first_proj: | ||
| "Congrats! You shared your first project!" | ||
| error_01: | ||
| Oops! That project couldn't be shared. Refresh and try again! | ||
| error_02: | ||
| The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug report. | ||
| tempbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | ||
| permbanned: | ||
| We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us. |
There was a problem hiding this comment.
These messages reference user accounts, project sharing, and banning functionality that doesn't exist in OmniBlocks. According to the project README, OmniBlocks explicitly has no account integration or login system. The messages for "welcome", "first_proj", "tempbanned", and "permbanned" all assume features that are not implemented and are not on the roadmap. Consider removing these or storing them in a design document outside the static directory if they represent long-term aspirational features.
| tempbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | ||
| permbanned: | ||
| We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us. |
There was a problem hiding this comment.
Spelling error: "belive" should be "believe".
| Oops! That project couldn't be shared. Refresh and try again! | ||
| error_02: | ||
| The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug report. | ||
| tempbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | ||
| permbanned: | ||
| We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us. |
There was a problem hiding this comment.
The file format appears inconsistent. Line 2 uses quotes around the message text, while lines 6 and 8 do not. Consider standardizing the format for consistency and easier parsing if this is intended to be machine-readable.
| Oops! That project couldn't be shared. Refresh and try again! | |
| error_02: | |
| The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug report. | |
| tempbanned: | |
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | |
| permbanned: | |
| We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us. | |
| "Oops! That project couldn't be shared. Refresh and try again!" | |
| error_02: | |
| "The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug report." | |
| tempbanned: | |
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | |
| permbanned: | |
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us." |
| welcome: | ||
| "Hello, {USERNAME}! Welcome to OmniBlocks!" | ||
| first_proj: | ||
| "Congrats! You shared your first project!" | ||
| error_01: | ||
| Oops! That project couldn't be shared. Refresh and try again! | ||
| error_02: | ||
| The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug report. | ||
| tempbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | ||
| permbanned: | ||
| We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us. |
There was a problem hiding this comment.
The file is placed in the static directory but is not being used by any code. Unused static files increase the build size. If these are truly future concepts, consider moving them to a documentation directory (e.g., docs/future-features.txt) or a separate design/planning directory outside of static/ which is intended for deployed assets.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
hmmm okk idk |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@static/futurefrontend/pagestextconcepts.txt`:
- Around line 1-12: The file uses inconsistent quoting for message values (keys:
welcome, first_proj, error_01, error_02, tempbanned, permbanned); standardize
all values to use quotes (e.g., wrap every message string in double quotes),
preserve interpolation placeholders like {USERNAME}, {REASON4BAN}, {MODNOTE},
{UNBANDATE} exactly, and escape any internal quotes if needed so the parser can
reliably read every entry (update welcome, first_proj, tempbanned to match
error_01, error_02, permbanned or vice versa so all six entries follow the same
quoted format).
🧹 Nitpick comments (3)
static/futurefrontend/pagestextconcepts.txt (3)
5-8: Consider reducing exclamation mark usage for a more professional tone.Static analysis detected 6 exclamation marks across 674 characters of text. For error messages and user notifications, a calmer tone is often more professional and less alarming. Consider using periods instead of exclamation marks for some messages, especially error messages.
1-12: Add documentation for the file format and integration plan.This file uses a custom format without documentation:
- No explanation of the key-value syntax
- No specification of placeholder syntax (
{VARIABLE})- No parser or usage examples provided
- No integration plan for how frontend code will consume this file
Consider adding:
- A README or header comment explaining the format
- Documentation of placeholder syntax and substitution rules
- Example code showing how to parse and use these messages
- A clear integration plan (which components will use this, when, how)
This will make it easier for team members to understand, maintain, and integrate these messages.
Would you like help creating a parser implementation or documentation for this format?
1-4: Clarify that these are aspirational features requiring future backend.This file contains UI messages for features that require backend infrastructure that doesn't currently exist in OmniBlocks (user accounts, project sharing, moderation system). Since the file is isolated in the
futurefrontend/directory and not imported anywhere, it's clearly speculative planning. Consider adding a comment or documentation explaining that these messages are for future features planned when backend infrastructure is implemented.
| welcome: | ||
| "Hello, {USERNAME}! Welcome to OmniBlocks!" | ||
| first_proj: | ||
| "Congrats! You shared your first project!" | ||
| error_01: | ||
| Oops! That project couldn't be shared. Refresh and try again! | ||
| error_02: | ||
| The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug report. | ||
| tempbanned: | ||
| "We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}." | ||
| permbanned: | ||
| We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us. |
There was a problem hiding this comment.
Inconsistent quotation mark usage could cause parsing issues.
The file has inconsistent formatting:
- Lines with quotes:
welcome(line 2),first_proj(line 4),tempbanned(line 10) - Lines without quotes:
error_01(line 6),error_02(line 8),permbanned(line 12)
If this file will be parsed programmatically, standardize the format to either always use quotes or never use quotes. The inconsistency could lead to parsing errors or unexpected behavior.
🔧 Proposed fix: Standardize to always use quotes
welcome:
"Hello, {USERNAME}! Welcome to OmniBlocks!"
first_proj:
"Congrats! You shared your first project!"
error_01:
-Oops! That project couldn't be shared. Refresh and try again!
+"Oops! That project couldn't be shared. Refresh and try again!"
error_02:
-The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug report.
+"The editor has encountered an internal issue and has crashed. Please check the error on the editor and send a bug report."
tempbanned:
"We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is temporary. You will be unbanned on {UNBANDATE}."
permbanned:
-We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us.
+"We're sorry, but you have been banned from OmniBlocks. Reason: {REASON4BAN}. {MODNOTE} This ban is permanent. You will not be unbanned. If you believe this is a mistake, please contact us."🧰 Tools
🪛 LanguageTool
[style] ~6-~6: Using many exclamation marks might seem excessive (in this case: 6 exclamation marks for a text that’s 674 characters long)
Context: ...ouldn't be shared. Refresh and try again! error_02: The editor has encountered an...
(EN_EXCESSIVE_EXCLAMATION)
🤖 Prompt for AI Agents
In `@static/futurefrontend/pagestextconcepts.txt` around lines 1 - 12, The file
uses inconsistent quoting for message values (keys: welcome, first_proj,
error_01, error_02, tempbanned, permbanned); standardize all values to use
quotes (e.g., wrap every message string in double quotes), preserve
interpolation placeholders like {USERNAME}, {REASON4BAN}, {MODNOTE}, {UNBANDATE}
exactly, and escape any internal quotes if needed so the parser can reliably
read every entry (update welcome, first_proj, tempbanned to match error_01,
error_02, permbanned or vice versa so all six entries follow the same quoted
format).
I don't like how everything is failing because I made some spelling mistakes :D |
|
|
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1884 🏁 Script executed: Length of output: 3046 🏁 Script executed: Length of output: 244181 🏁 Script executed: Length of output: 4496 🏁 Script executed: Length of output: 1139
The Good News: It's NOT about spelling! ✨Your text file ( The Bad News: Visual Regression Testing Bug 🐛What's actually happening:
The Error Message:This is about screenshots, not spelling! Your text file doesn't affect visual rendering at all. Solutions 🛠️Option 1: Just merge it (Recommended)
Option 2: Manually skip VRT
The real bug here is that VRT's file checking logic isn't working correctly for your PR. This needs to be fixed in the VRT workflow, but it's not your fault! 🙂 Would you like me to investigate why the VRT skip logic failed, or would you prefer to just have supervoidcoder merge this as-is? 🧠 Learnings used |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 7311 🏁 Script executed: Length of output: 12324 🏁 Script executed: Length of output: 140 🏁 Script executed: Length of output: 10407
Here's what's actually happening: The Real IssueThe Visual Regression Testing is failing due to infrastructure/timeout issues, not spelling errors. The actual errors are:
These failures are occurring in tests like "Editor - Code Tab", "Editor - Costumes Tab", "Editor - Sounds Tab", etc. — all unrelated to your static text file. Your File Is FineI reviewed
Why These Tests Are FailingAdding a static text file in
Next StepsYou could:
The important checks (CodeQL, file checks) all passed ✅. The visual regression failures are a test infrastructure issue, not a problem with your work. 🧠 Learnings used |
🤖 Auto-Component Test Results🎉 No new UI components detected!This PR doesn't add any new buttons, menus, or clickable components. Triggered by @Graison-P • Commit |
🎉 MEGA PR Test & Analysis Complete!Hi @Graison-P! Your PR has been fully tested and analyzed! 🚀✨ 🌍 Test DeploymentLive Preview: https://OmniBlocks.github.io/scratch-gui/Graison-P/773/ 🧪 Test ResultsESLint: ⏭️ Skipped (no JS/JSX files changed) Unit Tests: ✅
Integration Tests: ❌
📄 Full test outputs available in artifacts 🔦 Performance Audit (Lighthouse)✅ Audit completed successfully! 📊 Lighthouse Scores:
⚡ Core Web Vitals:
🟢 90-100 (Good) | 🟠 50-89 (Needs Improvement) | 🔴 0-49 (Poor) 📄 Full report in artifacts 📦 Bundle Size AnalysisTotal Build Size: 185M 📦 Top 5 Largest JavaScript Files:
🎨 Top 5 Largest CSS Files:
♿ Accessibility Testing✅ Accessibility scan completed!
📊 Build Details
💡 Pro Tip: Only one build was needed for all these checks - saving CI/CD minutes! 🎯 |
❌ ULTRA Visual Regression Testing - Tests FailedHi @Graison-P! The test matrix failed to produce any results. All 9 test combinations failed. This could be due to:
Please check the logs for details: The build phase completed successfully, but the test execution failed. |
|
@supervoidcoder @coderabbitai yk I hate when it puts an unrelated commit that is supposed to be in a separate PR into an unrelated one :D (ahem credits.html) |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
🏁 Script executed: Length of output: 1183 🏁 Script executed: Length of output: 74 🏁 Script executed: Length of output: 3955
What's in this PR now:File 1 (intended):
File 2 (accidental):
Your options to fix this:Option 1: Keep both changes together (easiest but not ideal)Just merge as-is. Both changes are good, just not related. Pros: Zero work, both get merged Option 2: Remove credits.html from this PR (cleanest)# On your local graisonscrap branch
git rebase -i HEAD~6 # Interactive rebase for last 6 commits
# In the editor, DELETE the line with "711495a change UB credits to also be for OB"
# Save and close
git push --force-with-lease origin graisonscrapThen create a separate PR for the credits update. Option 3: Start fresh
My recommendation:Option 2 is cleanest if you're comfortable with interactive rebase. The credits update deserves its own PR anyway since it's recognizing the OB dev team! 🎉 What would you prefer? 🧠 Learnings used |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@static/credits.html`:
- Line 70: The anchor display text in static/credits.html ("AmpEletrecuted") is
likely misspelled and should match the GitHub username `ampelectrecuted`; update
the anchor inner text to "AmpElectrecuted" (or confirm the correct preferred
spelling with the team member) so the link text and username are consistent;
locate the <a href="https://github.com/ampelectrecuted"> element and correct its
visible text accordingly.
- Around line 9-10: Update the meta description content in the <meta
name="description"> tag to reference "OmniBlocks" instead of "UltraBox" so it
matches the page title "OmniBlocks Credits"; locate the <meta
name="description"> element in the credits HTML (near the <title> tag) and
replace the string "UltraBox is a mod of BeepBox that aims to combine every
other beepmod into one." with a concise OmniBlocks-specific description.
- Around line 58-66: The page currently closes the body too early and places the
new credits markup outside the <body>, and it nests an <h3> inside an <h1>; move
the closing </body> so it wraps all visible content (i.e., place the final
</body> just before </html>), ensure all newly added credits sections are inside
that body, and refactor the heading structure so the <h3> is a sibling following
the <h1> (not a child) to correct invalid nesting.
🧹 Nitpick comments (1)
static/credits.html (1)
60-65: Deprecated<font>tag usage in new code.The
<font>element has been deprecated since HTML 4.01. While the existing credits section (line 89) already uses it, new code ideally shouldn't perpetuate the pattern. A simple CSS class would be cleaner, but this is consistent with the rest of the file so it's a nit.Also applies to: 81-81
| <meta name="description" content="UltraBox is a mod of BeepBox that aims to combine every other beepmod into one." /> | ||
| <title>UltraBox Credits</title> | ||
| <title>OmniBlocks Credits</title> |
There was a problem hiding this comment.
Meta description still references "UltraBox" while the title now says "OmniBlocks Credits".
Line 9's <meta name="description"> still describes UltraBox. Since the title and headers were updated to OmniBlocks, this description should be updated as well for consistency.
🤖 Prompt for AI Agents
In `@static/credits.html` around lines 9 - 10, Update the meta description content
in the <meta name="description"> tag to reference "OmniBlocks" instead of
"UltraBox" so it matches the page title "OmniBlocks Credits"; locate the <meta
name="description"> element in the credits HTML (near the <title> tag) and
replace the string "UltraBox is a mod of BeepBox that aims to combine every
other beepmod into one." with a concise OmniBlocks-specific description.
| </body> | ||
|
|
||
| <h1> | ||
| <font color="#FF8EC5">Credits</font> | ||
| <font color="#FF8EC5">OmniBlocks Credits</font> | ||
| <h3>Thanks to various community members for helping us build and fix issues along the way!</h3> | ||
| </h1> | ||
|
|
||
| <h1> | ||
| <font color="#FF8EC5">Developers</font> | ||
| </h1> |
There was a problem hiding this comment.
All page content sits outside <body> — the closing </body> on line 58 precedes every visible element.
The </body> tag at line 58 is pre-existing, but all newly added content (lines 59–86) and the rest of the page fall outside the <body> element. This is invalid HTML and browsers only render it correctly due to error recovery. Since this PR restructures the credits content, it would be a good time to move the </body> (and its matching close on line 228) to wrap all content properly.
Also, <h3> inside <h1> (line 61) is invalid nesting — heading elements cannot contain other headings. Consider placing the <h3> as a sibling after the <h1>.
Proposed structural fix (lines 58–66)
- </body>
-<h1>
-<font color="#FF8EC5">OmniBlocks Credits</font>
-<h3>Thanks to various community members for helping us build and fix issues along the way!</h3>
-</h1>
-
-<h1>
-<font color="#FF8EC5">Developers</font>
-</h1>
+<h1><font color="#FF8EC5">OmniBlocks Credits</font></h1>
+<h3>Thanks to various community members for helping us build and fix issues along the way!</h3>
+
+<h1><font color="#FF8EC5">Developers</font></h1>And move </body> to just before </html> at the end of the file.
🤖 Prompt for AI Agents
In `@static/credits.html` around lines 58 - 66, The page currently closes the body
too early and places the new credits markup outside the <body>, and it nests an
<h3> inside an <h1>; move the closing </body> so it wraps all visible content
(i.e., place the final </body> just before </html>), ensure all newly added
credits sections are inside that body, and refactor the heading structure so the
<h3> is a sibling following the <h1> (not a child) to correct invalid nesting.
|
|
||
| <h2><a href="https://github.com/supervoidcoder">supervoidcoder/greencuby</a> - the creator of OB!</h2> | ||
|
|
||
| <h2><a href="https://github.com/ampelectrecuted">AmpEletrecuted</a></h2> |
There was a problem hiding this comment.
Likely typo: "AmpEletrecuted" — should this be "AmpElectrecuted"?
The GitHub username is ampelectrecuted (with ctr), but the display text reads "AmpEletrecuted" (missing the c). Please verify the preferred spelling with the team member.
🤖 Prompt for AI Agents
In `@static/credits.html` at line 70, The anchor display text in
static/credits.html ("AmpEletrecuted") is likely misspelled and should match the
GitHub username `ampelectrecuted`; update the anchor inner text to
"AmpElectrecuted" (or confirm the correct preferred spelling with the team
member) so the link text and username are consistent; locate the <a
href="https://github.com/ampelectrecuted"> element and correct its visible text
accordingly.
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@static/credits.html`:
- Line 70: Replace the misspelled contributor display name in the credits HTML:
update the <h2> anchor text that currently reads "AmpEletrecuted" to the correct
GitHub username "ampelectrecuted" so the visible link text matches the actual
account.
- Around line 9-10: The meta description content still references "UltraBox"
while the page title uses "OmniBlocks Credits"; update the <meta
name="description"> value to reflect OmniBlocks (e.g., "OmniBlocks is a mod of
BeepBox..." or clarify scope like "Embedded UltraBox music editor used in
OmniBlocks") so the description matches the branding in the <title> tag and
accurately describes the page/editor.
- Around line 59-66: The HTML uses a nested <h3> inside an <h1> and the
deprecated <font> tag around the titles (e.g., "OmniBlocks Credits" and
"Developers"), causing invalid markup; fix by un-nesting headings so each
heading is its own element (use <h1> for the main title and a sibling <h3> or
<p> for the subtitle), remove the <font> tags and apply color via CSS (inline
style or a class), and apply the same changes to the "UltraaBox Credits" heading
to ensure valid, modern HTML.
🧹 Nitpick comments (1)
static/credits.html (1)
68-78: Consider using a<ul>list instead of<h2>for each developer.Using
<h2>for every contributor name creates a flat, heading-heavy document outline. A simple unordered list would be more semantically appropriate and easier to maintain as the team grows. The existing mod-credits section below uses<h2>per project (with sub-details), which is a different use case.
| <meta name="description" content="UltraBox is a mod of BeepBox that aims to combine every other beepmod into one." /> | ||
| <title>UltraBox Credits</title> | ||
| <title>OmniBlocks Credits</title> |
There was a problem hiding this comment.
Meta description still references "UltraBox" while the title was updated to "OmniBlocks Credits".
Line 9's <meta name="description"> still says "UltraBox is a mod of BeepBox…". If this page is being rebranded for OmniBlocks, the description should be updated to match — or at minimum clarified that the UltraBox description applies to the embedded music editor only.
🤖 Prompt for AI Agents
In `@static/credits.html` around lines 9 - 10, The meta description content still
references "UltraBox" while the page title uses "OmniBlocks Credits"; update the
<meta name="description"> value to reflect OmniBlocks (e.g., "OmniBlocks is a
mod of BeepBox..." or clarify scope like "Embedded UltraBox music editor used in
OmniBlocks") so the description matches the branding in the <title> tag and
accurately describes the page/editor.
| <h1> | ||
| <font color="#FF8EC5">Credits</font> | ||
| <font color="#FF8EC5">OmniBlocks Credits</font> | ||
| <h3>Thanks to various community members for helping us build and fix issues along the way!</h3> | ||
| </h1> | ||
|
|
||
| <h1> | ||
| <font color="#FF8EC5">Developers</font> | ||
| </h1> |
There was a problem hiding this comment.
Invalid HTML: <h3> nested inside <h1>, and deprecated <font> tag.
Heading elements cannot be nested inside other headings — this produces invalid HTML and unpredictable rendering. The same pattern repeats at lines 80–86. Also, <font> has been deprecated since HTML4; use CSS color instead.
Proposed fix for lines 59–66
<h1>
-<font color="#FF8EC5">OmniBlocks Credits</font>
-<h3>Thanks to various community members for helping us build and fix issues along the way!</h3>
-</h1>
-
-<h1>
-<font color="#FF8EC5">Developers</font>
+<span style="color:`#FF8EC5`">OmniBlocks Credits</span>
</h1>
+<h3>Thanks to various community members for helping us build and fix issues along the way!</h3>
+
+<h1>
+<span style="color:`#FF8EC5`">Developers</span>
+</h1>Apply the same fix to the "UltraaBox Credits" heading at line 80–81.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <h1> | |
| <font color="#FF8EC5">Credits</font> | |
| <font color="#FF8EC5">OmniBlocks Credits</font> | |
| <h3>Thanks to various community members for helping us build and fix issues along the way!</h3> | |
| </h1> | |
| <h1> | |
| <font color="#FF8EC5">Developers</font> | |
| </h1> | |
| <h1> | |
| <span style="color:`#FF8EC5`">OmniBlocks Credits</span> | |
| </h1> | |
| <h3>Thanks to various community members for helping us build and fix issues along the way!</h3> | |
| <h1> | |
| <span style="color:`#FF8EC5`">Developers</span> | |
| </h1> |
🤖 Prompt for AI Agents
In `@static/credits.html` around lines 59 - 66, The HTML uses a nested <h3> inside
an <h1> and the deprecated <font> tag around the titles (e.g., "OmniBlocks
Credits" and "Developers"), causing invalid markup; fix by un-nesting headings
so each heading is its own element (use <h1> for the main title and a sibling
<h3> or <p> for the subtitle), remove the <font> tags and apply color via CSS
(inline style or a class), and apply the same changes to the "UltraaBox Credits"
heading to ensure valid, modern HTML.
|
|
||
| <h2><a href="https://github.com/supervoidcoder">supervoidcoder/greencuby</a> - the creator of OB!</h2> | ||
|
|
||
| <h2><a href="https://github.com/ampelectrecuted">AmpEletrecuted</a></h2> |
There was a problem hiding this comment.
Typo in contributor name: "AmpEletrecuted" → "ampelectrecuted".
The display name has transposed letters ("Elet" instead of "Elect"). The actual GitHub username is ampelectrecuted.
Proposed fix
-<h2><a href="https://github.com/ampelectrecuted">AmpEletrecuted</a></h2>
+<h2><a href="https://github.com/ampelectrecuted">AmpElectrecuted</a></h2>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <h2><a href="https://github.com/ampelectrecuted">AmpEletrecuted</a></h2> | |
| <h2><a href="https://github.com/ampelectrecuted">AmpElectrecuted</a></h2> |
🤖 Prompt for AI Agents
In `@static/credits.html` at line 70, Replace the misspelled contributor display
name in the credits HTML: update the <h2> anchor text that currently reads
"AmpEletrecuted" to the correct GitHub username "ampelectrecuted" so the visible
link text matches the actual account.
2 participants
This PR adds a txt file with some concept frontend messages for users