feat: add synchronous getJsBundlePath to Nitro module#24
Closed
huhuanming wants to merge 2 commits intomainfrom
Closed
feat: add synchronous getJsBundlePath to Nitro module#24huhuanming wants to merge 2 commits intomainfrom
huhuanming wants to merge 2 commits intomainfrom
Conversation
…hAsync Nitro module now exposes a synchronous getJsBundlePath() alongside the async getJsBundlePathAsync(), matching the getWebEmbedPath pattern. This is needed for polyfillsPlatform.js which runs at module load time.
huhuanming
force-pushed
the
feat/sync-getJsBundlePath
branch
from
9c7b9fe to
830ffe6
Compare
huhuanming
force-pushed
the
feat/sync-getJsBundlePath
branch
from
830ffe6 to
87caf5d
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getJsBundlePath(): stringto the Nitro BundleUpdate module (iOS + Android)getJsBundlePathAsync(): Promise<string>, matching thegetWebEmbedPath/getWebEmbedPathAsyncpatternpolyfillsPlatform.jswhich runs synchronously at module load time to resolve asset paths after hot updateTest plan
getJsBundlePath()returns correctmain.jsbundle.hbcpath on iOSgetJsBundlePath()returns correctmain.jsbundle.hbcpath on AndroidgetJsBundlePathAsync()still works in existing async call sites