Skip to content

remove a pdsc entry in local repository if not found as installed pack#694

Merged
bgn42 merged 6 commits intomainfrom
rm_local_issue683
Feb 18, 2026
Merged

remove a pdsc entry in local repository if not found as installed pack#694
bgn42 merged 6 commits intomainfrom
rm_local_issue683

Conversation

@bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Feb 17, 2026

Fixes

Changes

  • search for a matching pdsc in local repository if not found installed

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds the ability to remove pack entries from local_repository.pidx using the cpackget rm command when the pack is not installed as a regular pack. Previously, users had to manually edit the local_repository.pidx file to remove pack references that were added via PDSC files.

Changes:

  • Modified PackIsInstalled to detect packs that exist only in local_repository.pidx when the installation directory doesn't exist
  • Updated RemovePack to call RemovePdsc when a pack is found in the local repository but not installed as a regular pack

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qltysh
Copy link

qltysh bot commented Feb 17, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on main by 0.54%.

Modified Files with Diff Coverage (6)

RatingFile% DiffUncovered Line #s
Coverage rating: C Coverage rating: C
cmd/xml/pidx.go0.0%498-500
Coverage rating: D Coverage rating: D
cmd/installer/root.go71.4%326-327, 334-335...
Coverage rating: B Coverage rating: C
cmd/installer/pdsc.go69.2%132-133, 136, 145
Coverage rating: B Coverage rating: B
cmd/installer/pack.go100.0%
Coverage rating: C Coverage rating: C
cmd/utils/packs.go33.3%87-88
Coverage rating: B Coverage rating: C
cmd/utils/utils.go16.1%43-75
Total47.7%
🤖 Increase coverage with AI coding...

In the `rm_local_issue683` branch, add test coverage for this new code:

- `cmd/installer/pdsc.go` -- Lines 132-133, 136, and 145
- `cmd/installer/root.go` -- Lines 326-327, 334-335, 339-341, and 1912-1914
- `cmd/utils/packs.go` -- Line 87-88
- `cmd/utils/utils.go` -- Line 43-75
- `cmd/xml/pidx.go` -- Line 498-500

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Test Results

    4 files  ±0     24 suites  ±0   1m 47s ⏱️ +13s
  769 tests ±0    769 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 059 runs  ±0  3 059 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ec03ff4. ± Comparison against base commit 777d48b.

♻️ This comment has been updated with latest results.

@bgn42 bgn42 requested a review from jkrech February 18, 2026 13:42
jkrech
jkrech previously approved these changes Feb 18, 2026
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgn42 bgn42 merged commit 2b04569 into main Feb 18, 2026
23 of 24 checks passed
@bgn42 bgn42 deleted the rm_local_issue683 branch February 18, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments