Added badges to the README.md file#686
Added badges to the README.md file#686Evagan2018 wants to merge 1 commit intoOpen-CMSIS-Pack:mainfrom
Conversation
KeilChris
left a comment
There was a problem hiding this comment.
Why do we have three license badges? The Apache 2.0 and GPL v3.0 and later should suffice.
jreineckearm
left a comment
There was a problem hiding this comment.
I am about to head off into the weekend. I'll mark as "request changes" as I'd like to understand why we need this huge amount of badges.
Also, I added this in the past to the workflow to remove them before packaging the VSIX file for consumption in VS Code:
These reflect the current state of the repo, which may be misinterpreted as the state of the VSIX that the user installed.
Let's discuss next week if these badges should show in the extension installation, too.
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/dependency-review.yml) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/scorecard.yml) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/tpip.yml) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/nightly.yml) |
There was a problem hiding this comment.
This should be called Nightly like the workflow.
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/blob/main/LICENSE-Apache-2.0) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/blob/main/LICENSE) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/blob/main/LICENSE-GPL-3.0-or-later) | ||
| [](https://github.com/Open-CMSIS-Pack/vscode-cmsis-debugger/tree/main/.github/workflows/ci.yml) |
There was a problem hiding this comment.
This workflow runs test results but is also used for publishing.
Is this reflecting the last run for a specific branch, or for the whole repo?
|
Coming back to this...my suggestion is to only add the following badges:
UPDATE: We probably can live without the Arm logo for the new badges? No strong opinion though. Let's see how cluttered the area is with that. Update these workflow steps to remove newly added badges before VSIX packaging. The links aren't snapshots of a release but life data. And I don't see user value having them in a VSIX release: |
Fixes
Changes
-Added badges to the README.md file
Screenshots
Checklist