Skip to content

Change smells reporting mode from comment to review#729

Draft
soumeh01 wants to merge 1 commit intomainfrom
qlty_review_config
Draft

Change smells reporting mode from comment to review#729
soumeh01 wants to merge 1 commit intomainfrom
qlty_review_config

Conversation

@soumeh01
Copy link
Collaborator

Changes

  • The review mode is designed to prevent duplicate comments by tracking which issues have already been reported, whereas comment mode would add comments every time regardless of whether they were already present. I would try this change and monitor if this actually resolves the issue.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

The review mode is designed to prevent duplicate comments by tracking which issues have already been reported, whereas comment mode would add comments every time regardless of whether they were already present.
@soumeh01 soumeh01 marked this pull request as ready for review January 12, 2026 17:33
@soumeh01 soumeh01 requested a review from jreineckearm January 12, 2026 17:34
@qltysh
Copy link

qltysh bot commented Jan 12, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately seems like there is no review mode: https://docs.qlty.sh/analysis-configuration#check-modes 😕

See qlty error output

qlty check --no-upgrade-check --install-only --upstream origin/main
   ERROR   
 > There was an error reading your qlty.toml config file.
 > 
 > Please make sure you are using the latest version of the CLI with `qlty upgrade`.
 > 
 > For more information, please visit: https://docs.qlty.sh/qlty-toml
 > 
 > Caused by:
 >     0: This TOML configuration file is not valid to Qlty: /home/runner/work/vscode-cmsis-debugger/.qlty/qlty.toml
 >     1: Invalid TOML configuration
 >     2: enum IssueMode does not have variant constructor review for key `smells.mode`

@soumeh01 soumeh01 marked this pull request as draft January 12, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments