Change smells reporting mode from comment to review#729
Draft
Change smells reporting mode from comment to review#729
Conversation
The review mode is designed to prevent duplicate comments by tracking which issues have already been reported, whereas comment mode would add comments every time regardless of whether they were already present.
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
Collaborator
jreineckearm
left a comment
There was a problem hiding this comment.
Unfortunately seems like there is no review mode: https://docs.qlty.sh/analysis-configuration#check-modes 😕
See qlty error output
qlty check --no-upgrade-check --install-only --upstream origin/main
ERROR
> There was an error reading your qlty.toml config file.
>
> Please make sure you are using the latest version of the CLI with `qlty upgrade`.
>
> For more information, please visit: https://docs.qlty.sh/qlty-toml
>
> Caused by:
> 0: This TOML configuration file is not valid to Qlty: /home/runner/work/vscode-cmsis-debugger/.qlty/qlty.toml
> 1: Invalid TOML configuration
> 2: enum IssueMode does not have variant constructor review for key `smells.mode`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
reviewmode is designed to prevent duplicate comments by tracking which issues have already been reported, whereascommentmode would add comments every time regardless of whether they were already present. I would try this change and monitor if this actually resolves the issue.Checklist