Skip to content

Prompting users to reload vscode window for proper manifest updates#811

Draft
omarArm wants to merge 15 commits intomainfrom
debugTreeViewRegisteration
Draft

Prompting users to reload vscode window for proper manifest updates#811
omarArm wants to merge 15 commits intomainfrom
debugTreeViewRegisteration

Conversation

@omarArm
Copy link
Collaborator

@omarArm omarArm commented Feb 11, 2026

Fixes

Changes

  • Followed same initiation pattern as that of Live Watch
  • Added a new reload window to prompt users to reload their vscode windows to update vscode manifest

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Feb 11, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-main.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@omarArm omarArm marked this pull request as ready for review February 11, 2026 17:16
@omarArm omarArm requested a review from jreineckearm February 11, 2026 17:16
@omarArm omarArm requested a review from Copilot February 12, 2026 08:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds additional logging around Component Viewer Tree View registration and aligns its initialization pattern with Live Watch by instantiating and injecting the tree data provider from the extension activation flow.

Changes:

  • Inject ComponentViewerTreeDataProvider into ComponentViewer via constructor (instead of instantiating internally).
  • Add log statements around Component Viewer activation and tree/command registration.
  • Update unit tests to construct ComponentViewer with a provider helper.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/views/component-viewer/test/unit/component-viewer-main.test.ts Updates tests to use a shared createController(...) helper that injects a tree provider.
src/views/component-viewer/component-viewer-main.ts Changes ComponentViewer to require an injected tree provider and adds logs during activation/registration.
src/desktop/extension.ts Creates and wires a ComponentViewerTreeDataProvider during activation; clears provider on deactivate; adds activation logs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jreineckearm jreineckearm marked this pull request as draft February 12, 2026 17:14
@omarArm omarArm marked this pull request as ready for review February 17, 2026 12:03
@omarArm omarArm changed the title adding log messages to track treeView registration Prompting users to reload vscode window for proper manifest updates Feb 17, 2026
@omarArm omarArm marked this pull request as draft February 17, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants