Skip to content

scheduling an update when an instance is unlocked#833

Merged
jreineckearm merged 4 commits intomainfrom
updateOnUnlock
Feb 18, 2026
Merged

scheduling an update when an instance is unlocked#833
jreineckearm merged 4 commits intomainfrom
updateOnUnlock

Conversation

@omarArm
Copy link
Collaborator

@omarArm omarArm commented Feb 18, 2026

Fixes

Changes

  • Triggering an update when an instance is unlocked

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Feb 18, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-main.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Issue #810 by ensuring the Component Viewer schedules a refresh/update when a previously locked SCVD root instance is unlocked, so the GUI can catch up after being held.

Changes:

  • Renames/extends the update-reason type (fifoUpdateReasonUpdateReason) and adds a new reason for unlocking.
  • Triggers schedulePendingUpdate('unlockingInstance') when an instance transitions from locked → unlocked.
  • Adds unit tests verifying update scheduling behavior on lock vs unlock.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/views/component-viewer/component-viewer-main.ts Adds unlockingInstance update reason and schedules an update when unlocking an instance.
src/views/component-viewer/test/unit/component-viewer-main.test.ts Updates types and adds tests for unlock-triggered scheduling behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works nicely.

@jreineckearm jreineckearm merged commit e69954d into main Feb 18, 2026
20 checks passed
@jreineckearm jreineckearm deleted the updateOnUnlock branch February 18, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments