Skip to content

showing lock status on component viewer instances#836

Merged
thorstendb-ARM merged 2 commits intomainfrom
showLockStatus
Feb 18, 2026
Merged

showing lock status on component viewer instances#836
thorstendb-ARM merged 2 commits intomainfrom
showLockStatus

Conversation

@omarArm
Copy link
Collaborator

@omarArm omarArm commented Feb 18, 2026

Changes

  • Added a lock status icon on the left of component viewer instances

Screenshots

image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Feb 18, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-tree-view.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

thorstendb-ARM
thorstendb-ARM previously approved these changes Feb 18, 2026
Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, great!

@omarArm omarArm requested a review from jreineckearm February 18, 2026 15:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds visual indication of lock status for component viewer instances by displaying a lock icon next to locked root instances in the tree view.

Changes:

  • Added lock icon display for locked root instances in the component viewer tree
  • Updated test infrastructure to support ThemeIcon mocking
  • Added test coverage for lock icon assignment behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/views/component-viewer/component-viewer-tree-view.ts Implements lock icon display logic for locked root instances
src/views/component-viewer/test/unit/component-viewer-tree-view.test.ts Adds ThemeIcon mock and test case for lock icon functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still works :-)
Also does not update just by clicking unlock, which is great (but does, if required)!

@thorstendb-ARM thorstendb-ARM merged commit dfdc8c2 into main Feb 18, 2026
19 of 20 checks passed
@thorstendb-ARM thorstendb-ARM deleted the showLockStatus branch February 18, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments