This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Fix vendor dir relative to build dir in extension requires#575
Open
GregSutcliffe wants to merge 1 commit intoOpenACalendar:masterfrom
Open
Fix vendor dir relative to build dir in extension requires#575GregSutcliffe wants to merge 1 commit intoOpenACalendar:masterfrom
GregSutcliffe wants to merge 1 commit intoOpenACalendar:masterfrom
Conversation
Member
|
In fact, looking at it, it doesn't actually need either autoload.php for what follows. So maybe it should just be removed totally. Will have a look. |
jarofgreen
added a commit
to OpenACalendar/OpenACalendar-Documentation-SuperUsers
that referenced
this pull request
Mar 17, 2016
Actually, that might not always be technically true. But a) if your writing extensions you'll probably need them anyway at some point b) this fixes a bug in v1.6.0 where php build/newExtension.php required them. OpenACalendar/OpenACalendar-Web-Core#575
Member
|
Leaving open: look at removing the require line so even if build tools not installed it won’t crash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to work locally.