Fix SSD1306 build#263
Merged
julianneswinoga merged 3 commits intoOpenAstroTech:developfrom Apr 7, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #262
INFO_DISPLAY_TYPE, but only formksgenlv21andesp32DISPLAY_TYPEORINFO_DISPLAY_TYPE, not bothINFO_DISPLAY_TYPEand a focus motor (from their pin configuration)https://github.com/ClutchplateDude/esp8266-oled-ssd1306#4.6.0tag specifier, because the4.6.0tag is before @ClutchplateDude fixed the library.4.6.2tag is now correct.esp32build withINFO_DISPLAY_TYPE_I2C_SSD1306_128x64was just broken?pgm_read_byte()onesp32(which is just a pointer cast becauseesp32doesn't actually havePROGMEM) does a useless cast which fails with our warning flags