Merged
Conversation
- `udpardTxPeek` now returns mutable item - needed for payload ownership transfer. - `udpardTxPop` now accepts mutable item - eliminated private `TxItem` Also: - fixed Sonar warning: property 'sonar.cfamily.build-wrapper-output' is deprecated
There was a problem hiding this comment.
Pull request overview
This pull request introduces LibUDPard v2.0 alpha, a major version update that refactors the TX pipeline memory management system. The primary change splits single-allocation TX items into a two-allocation pattern, separating fragment metadata from payload data. This enables better memory control, zero-fragmentation block allocation strategies, and payload ownership transfer capabilities.
- TX memory allocation refactored from 1 to 2 allocations per datagram (fragment + payload)
- New
UdpardTxMemoryResourcesstructure with separate memory resources for fragments and payloads - Mutable
datagram_payloadfield inUdpardTxItemto support payload ownership transfer - Comprehensive test updates to reflect doubled allocation counts and new memory patterns
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libudpard/udpard.h | Defines new UdpardTxMemoryResources structure, updates API signatures, adds priority field to UdpardTxItem, changes major version to 2 |
| libudpard/udpard.c | Implements two-allocation pattern in txNewItem, updates udpardTxFree to deallocate both fragment and payload, adds memory validation |
| tests/src/test_tx.cpp | Updates tests to use UdpardTxMemoryResources, changes allocation count assertions from N to N*2 |
| tests/src/test_intrusive_tx.c | Adapts tests for new memory structure, updates udpardTxFree usage, removes manual memFree calls |
| tests/src/test_intrusive_rx.c | Formatting updates for consistent compound literal spacing |
| tests/src/test_e2e.cpp | Updates end-to-end tests with new memory resources and allocation expectations |
| tools/run_sonar.sh | Switches from build-wrapper to compile-commands for SonarQube analysis |
| tests/.clang-tidy | Disables boost-use-ranges and modernize-use-ranges checks |
| .clang-tidy | Disables boost-use-ranges check |
| .github/workflows/main.yml | Updates LLVM version to 19, container to ts24.4.3, clang-format-lint-action to v0.20 |
| README.md | Adds v2.0 section referencing migration guide |
| MIGRATION_v1.x_to_v2.0.md | New comprehensive migration guide with code examples and step-by-step instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to merge this into main even though it is not yet stable.