[patina_mm] refactor current folder structure to allow external consumption#1413
[patina_mm] refactor current folder structure to allow external consumption#1413kuqin12 wants to merge 29 commits intoOpenDevicePartnership:mainfrom
Conversation
✅ QEMU Validation PassedAll QEMU validation jobs completed successfully.
Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/23364111544 Boot Time to EFI Shell
Dependencies
This comment was automatically generated by the Patina QEMU PR Validation Post workflow. |
| }; | ||
|
|
||
| let request_bytes = unblock_mem_request.to_bytes(); | ||
| let request_bytes = unblock_mem_request.as_bytes().to_vec(); |
There was a problem hiding this comment.
not sure what is going on with this one...
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@makubacki Curious to get your thoughts here but seeing as this particular crate ( I'm wondering if we should move common definitions for patina_mm related things into the |
I haven't looked at the PR changes yet, but I agree with your reasoning. Components provide functionality, not public definitions. Yes, common definitions should be moved to the sdk/patina crate. |
Sounds good. Will update accordingly. |
|
Okay, moved the non-alloc related definitions (header structures, constants, protocols) to patina and updated the consumers to use the new definitions. |
Description
Current patina_mm carries some definitions that can be shared by external users (mm communication header, buffer status, etc).
This change moves those files to a sub-module that does not require alloc.
It also separates the supervisor related definitions into its own file.
How This Was Tested
This was tested with local builds and booted to UEFI shell.
Integration Instructions
N/A