-
Notifications
You must be signed in to change notification settings - Fork 61
fix: add validation for edge expressions #4009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4009 +/- ##
==========================================
+ Coverage 88.76% 88.80% +0.04%
==========================================
Files 422 422
Lines 19106 19106
==========================================
+ Hits 16959 16968 +9
+ Misses 2147 2138 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
While working on this. spotted some wrong behaviours in the coloring of edges red based on the errors they were facing. lightning/assets/js/collaborative-editor/hooks/useValidation.ts Lines 79 to 108 in 9cad92e
|
55de1d2 to
c6c681c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @doc-han I see 3 things that look like problems we need to address. Now I am not super sure whether this is related to this issue / pr.
- When I type in the edge label I don't see it appear in the edge
- When I type a valid JS Expression I don't see the error disappear; it stays
- When I hit the save button, I see that
Edges: [object Oject]in the error message.
|
Nice catch @elias-ba |
|
Several things out of scope of this PR in relation to what you raised @elias-ba. |
Description
This PR add validation for edge expressions when you switch the condition to it. makes sure to show an error when its blank.
Closes #3704
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)