Enable zstd compression format#640
Conversation
bwlang
left a comment
There was a problem hiding this comment.
@sfchen I tested this locally. It compiled and worked as expected for reading zstd compressed inputs - including with larger files (10k reads). I also tested interleaved fastq.zst files successfully
I think it could be merged, maybe without the .gitignore modification.
.gitignore
Outdated
| *.html No newline at end of file | ||
| *.html | ||
|
|
||
| out/ No newline at end of file |
There was a problem hiding this comment.
I think this is a local preference
There was a problem hiding this comment.
Yes. This have been updated.
|
we r working on this, BTW which downstream sw support consume fq.zst? |
|
@KimBioInfoStudio Precellar https://github.com/regulatory-genomics/precellar, and lots of snakemake pipeline https://github.com/regulatory-genomics/ATAC-sm |
|
seems, most upstream basecalling not support output r1.fq.zst even BGZF, welcome pr, could u rebase it to latest master branch, BTW, we r seeking a better format which support indexed multi members and read parallelism |
Done. |
KimBioInfoStudio
left a comment
There was a problem hiding this comment.
Pls use lfs track those files?
|
I tried Git LFS, but GitHub does not allow uploading new LFS objects to my public fork (rejected by server). |
|
could u help with one group of bench as evidence
|
|
@sfchen plz kindly consider merge this pr |
zstdandard(zstd) is a compression algorithm with higher performance than zlib. This contribution enabled fastp to handle zstd format