fixed bug with overwriting user set min/max light values #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periodic_sun_phase_check() was overwriting the min/max voltage values with the plant stage values every time, regardless of user set min/max values in the UI. reused checkPlantStageLightValue() to fix it and adding LOGGER
Collaborator
|
Thanks will check and validate if it's applicable on the new version that I didn't push. |
Collaborator
|
can you check if the bug still happens with the new code i pushed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIX in light control
periodic_sun_phase_check() was overwriting the min/max voltage values with the plant stage values every time, regardless of user-set min/max values in the UI. Reused checkPlantStageLightValue() to fix it, and added LOGGER