fix(acp): replace global _ACP_CACHE_DIR with @lru_cache#559
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
fix(acp): replace global _ACP_CACHE_DIR with @lru_cache#559github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Replaces module-level global state for caching the ACP cache directory
with functools.lru_cache decorator. This is a cleaner pattern that
avoids mutable module-level state while maintaining the same lazy
initialization behavior.
Before:
_ACP_CACHE_DIR: Path | None = None
def get_acp_cache_dir() -> Path:
global _ACP_CACHE_DIR
if _ACP_CACHE_DIR is None:
_ACP_CACHE_DIR = ...
return _ACP_CACHE_DIR
After:
@lru_cache(maxsize=1)
def get_acp_cache_dir() -> Path:
cache_dir = ...
return cache_dir
Addresses item from code quality report.
Closes #557
Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces module-level global state for caching the ACP cache directory with
functools.lru_cachedecorator. This is a cleaner pattern that avoids mutable module-level state while maintaining the same lazy initialization behavior.Changes
_ACP_CACHE_DIRvariable@lru_cache(maxsize=1)decorator toget_acp_cache_dir()functionBefore:
After:
Related Issue
Addresses findings from #557
Testing
make lint)make test) - 1261 tests passedThis PR was automatically generated by the Code Quality Report workflow.