Conversation
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Taste Rating: Needs Improvement
The agent-sdk link fix is correct, but the Python version change creates a mismatch with actual project requirements.
|
|
||
| ## Coding Style & Naming Conventions | ||
| - Python 3.12, ruff formatting (88-char line limit, double quotes). | ||
| - Python 3.12.12, ruff formatting (88-char line limit, double quotes). |
There was a problem hiding this comment.
🔴 Critical: Documentation Mismatch
This change claims the project requires Python 3.12.12, but your actual configuration says otherwise:
pyproject.toml:requires-python = "==3.12.*"(any 3.12.x works)pyproject.tomlpyright:pythonVersion = "3.12"- CI workflows:
python-version: '3.12'
Problem: Developers will be confused about whether they need exactly 3.12.12 or if 3.12.13+ will work. Documentation should match reality.
Is this solving a real problem? Does the project actually break on 3.12.0-3.12.11? If not, you're adding false precision that will confuse contributors.
Fix: Either keep it as "Python 3.12" to match pyproject.toml, or if you genuinely need 3.12.12+, update pyproject.toml to requires-python = ">=3.12.12,<3.13" and explain why in the commit message.
| - Python 3.12.12, ruff formatting (88-char line limit, double quotes). | |
| - Python 3.12, ruff formatting (88-char line limit, double quotes). |
Fix link to agent-sdk and specify the latest Python patch version from 3.12 minor.
🚀 Try this PR