Skip to content

Update agent-sdk example link and Python version#563

Open
enyst wants to merge 1 commit intomainfrom
enyst-patch-2
Open

Update agent-sdk example link and Python version#563
enyst wants to merge 1 commit intomainfrom
enyst-patch-2

Conversation

@enyst
Copy link
Collaborator

@enyst enyst commented Mar 3, 2026

Fix link to agent-sdk and specify the latest Python patch version from 3.12 minor.


🚀 Try this PR

uvx --python 3.12 git+https://github.com/OpenHands/OpenHands-CLI.git@enyst-patch-2

Copy link
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Taste Rating: Needs Improvement

The agent-sdk link fix is correct, but the Python version change creates a mismatch with actual project requirements.


## Coding Style & Naming Conventions
- Python 3.12, ruff formatting (88-char line limit, double quotes).
- Python 3.12.12, ruff formatting (88-char line limit, double quotes).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical: Documentation Mismatch

This change claims the project requires Python 3.12.12, but your actual configuration says otherwise:

  • pyproject.toml: requires-python = "==3.12.*" (any 3.12.x works)
  • pyproject.toml pyright: pythonVersion = "3.12"
  • CI workflows: python-version: '3.12'

Problem: Developers will be confused about whether they need exactly 3.12.12 or if 3.12.13+ will work. Documentation should match reality.

Is this solving a real problem? Does the project actually break on 3.12.0-3.12.11? If not, you're adding false precision that will confuse contributors.

Fix: Either keep it as "Python 3.12" to match pyproject.toml, or if you genuinely need 3.12.12+, update pyproject.toml to requires-python = ">=3.12.12,<3.13" and explain why in the commit message.

Suggested change
- Python 3.12.12, ruff formatting (88-char line limit, double quotes).
- Python 3.12, ruff formatting (88-char line limit, double quotes).

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL661093385% 
report-only-changed-files is enabled. No files were changed during this commit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants