tui: add tab navigation hint to footers (#512)#581
Open
ixchio wants to merge 3 commits intoOpenHands:mainfrom
Open
tui: add tab navigation hint to footers (#512)#581ixchio wants to merge 3 commits intoOpenHands:mainfrom
ixchio wants to merge 3 commits intoOpenHands:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #512.
As per the user feedback, navigating fields inside the CLI modals and screens exclusively with the
Tabkey was atypical and unintuitive, leaving users to think the application was broken.To improve discoverability:
Tabkey binding globally to the main Application viaOpenHandsApp.SettingsScreenmodal to explicitly include aFooterand added theTabkey to its bindings list as well.Evidence of Changes
make lintand the changes are formatting-compliant.make testfor regression tests.make test-snapshots --snapshot-updateto capture the new footer text logic showing "Tab Navigate".I hope this helps new users get to their setup much quicker! Let me know if there's anything else you need.