docs: prefer upstream PR branches in code review guidance#382
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟡 Acceptable - Solves a real problem (false positive reviews when docs match upstream PRs) with a simple solution. Minor clarity issues that could confuse readers.
Verdict: ✅ Worth merging after addressing the inconsistency
Key Insight: The grep example contradicts the new guidance by still searching the main branch instead of the PR branch.
Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟡 Acceptable - Solves a real problem (false positive reviews when docs correctly match upstream PRs) with a straightforward solution. One minor clarity improvement suggested.
Verdict: ✅ Worth merging after addressing the ambiguity, or merge as-is if you think the instruction is clear enough.
Key Insight: The "replace" instruction could be misread as "edit this file" rather than "run this command instead of that one."
Co-authored-by: OpenHands Bot <contact@all-hands.dev>
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟡 Acceptable - Solves a real workflow problem (false positive reviews when docs correctly match upstream PRs) with a straightforward solution.
Verdict: ✅ Ready to merge
Key Insight: Pragmatic documentation fix that aligns reviewer behavior with the actual sync workflow - check the right source of truth when docs intentionally lead upstream changes.
Summary
Testing