Fix model configuration typo in GPT-5.3 Codex#2308
Draft
juanmichelini wants to merge 3 commits intomainfrom
Draft
Fix model configuration typo in GPT-5.3 Codex#2308juanmichelini wants to merge 3 commits intomainfrom
juanmichelini wants to merge 3 commits intomainfrom
Conversation
Contributor
API breakage checks (Griffe)Result: Failed Log excerpt (first 1000 characters) |
Contributor
Agent server REST API breakage checks (OpenAPI)Result: Passed |
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
Taste Rating: 🟡 Acceptable (with critical fixes needed)
Verdict: ❌ Needs rework - Tests not updated, incomplete change
Key Insight: Consistency fix is good taste, but you broke the tests.
The model naming change from gpt-5-3-codex to gpt-5.3-codex makes sense for consistency with other models (e.g., gpt-5.2-codex), but this PR is incomplete.
Contributor
🧪 Integration Tests ResultsOverall Success Rate: 0.0% 📊 Summary
📋 Detailed Resultslitellm_proxy_gpt_5.3_codex
Skipped Tests:
Failed Tests:
|
Fix test_gpt_5_3_codex_config to reference the corrected model key 'gpt-5.3-codex' (with dots) instead of the old 'gpt-5-3-codex' (with hyphens) to match the fix in resolve_model_config.py. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model contained id gpt-5-3-codex while the correct one was gpt-5.3-codex.
Testing here https://github.com/OpenHands/software-agent-sdk/actions/runs/22690678388
Checklist
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.12-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:19aa11c-pythonRun
All tags pushed for this build
About Multi-Architecture Support
19aa11c-python) is a multi-arch manifest supporting both amd64 and arm6419aa11c-python-amd64) are also available if needed