Skip to content

Add gpt-5.4-codex to resolve_model_config.py#2376

Draft
juanmichelini wants to merge 2 commits intomainfrom
gpt-5.4-codex
Draft

Add gpt-5.4-codex to resolve_model_config.py#2376
juanmichelini wants to merge 2 commits intomainfrom
gpt-5.4-codex

Conversation

@juanmichelini
Copy link
Collaborator

@juanmichelini juanmichelini commented Mar 10, 2026

This PR adds gpt-5.4-codex to resolve_model_config.py.


Agent Server images for this PR

GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server

Variants & Base Images

Variant Architectures Base Image Docs / Tags
java amd64, arm64 eclipse-temurin:17-jdk Link
python amd64, arm64 nikolaik/python-nodejs:python3.13-nodejs22 Link
golang amd64, arm64 golang:1.21-bookworm Link

Pull (multi-arch manifest)

# Each variant is a multi-arch manifest supporting both amd64 and arm64
docker pull ghcr.io/openhands/agent-server:ce82ca1-python

Run

docker run -it --rm \
  -p 8000:8000 \
  --name agent-server-ce82ca1-python \
  ghcr.io/openhands/agent-server:ce82ca1-python

All tags pushed for this build

ghcr.io/openhands/agent-server:ce82ca1-golang-amd64
ghcr.io/openhands/agent-server:ce82ca1-golang_tag_1.21-bookworm-amd64
ghcr.io/openhands/agent-server:ce82ca1-golang-arm64
ghcr.io/openhands/agent-server:ce82ca1-golang_tag_1.21-bookworm-arm64
ghcr.io/openhands/agent-server:ce82ca1-java-amd64
ghcr.io/openhands/agent-server:ce82ca1-eclipse-temurin_tag_17-jdk-amd64
ghcr.io/openhands/agent-server:ce82ca1-java-arm64
ghcr.io/openhands/agent-server:ce82ca1-eclipse-temurin_tag_17-jdk-arm64
ghcr.io/openhands/agent-server:ce82ca1-python-amd64
ghcr.io/openhands/agent-server:ce82ca1-nikolaik_s_python-nodejs_tag_python3.13-nodejs22-amd64
ghcr.io/openhands/agent-server:ce82ca1-python-arm64
ghcr.io/openhands/agent-server:ce82ca1-nikolaik_s_python-nodejs_tag_python3.13-nodejs22-arm64
ghcr.io/openhands/agent-server:ce82ca1-golang
ghcr.io/openhands/agent-server:ce82ca1-java
ghcr.io/openhands/agent-server:ce82ca1-python

About Multi-Architecture Support

  • Each variant tag (e.g., ce82ca1-python) is a multi-arch manifest supporting both amd64 and arm64
  • Docker automatically pulls the correct architecture for your platform
  • Individual architecture tags (e.g., ce82ca1-python-amd64) are also available if needed

Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
@github-actions
Copy link
Contributor

API breakage checks (Griffe)

Result: Passed

Action log

@github-actions
Copy link
Contributor

Agent server REST API breakage checks (OpenAPI)

Result: Failed

Log excerpt (first 1000 characters)
{"asctime": "2026-03-10 14:04:30,703", "levelname": "WARNING", "name": "openhands.agent_server.config", "filename": "config.py", "lineno": 173, "message": "\u26a0\ufe0f OH_SECRET_KEY was not defined. Secrets will not be persisted between restarts."}
::error title=openhands-agent-server REST API::Breaking REST API change detected without MINOR version bump (1.12.0 -> 1.12.0).

Breaking REST API changes detected compared to baseline release:
- the 'file' request property type/format changed from 'string'/'' to 'string'/'binary'
/home/runner/work/software-agent-sdk/software-agent-sdk/.venv/lib/python3.13/site-packages/litellm/llms/custom_httpx/async_client_cleanup.py:66: DeprecationWarning: There is no current event loop
  loop = asyncio.get_event_loop()

Action log

Copy link
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Clean addition following existing pattern.

This change is technically sound and follows the established pattern perfectly. However, since this modifies evaluation harness code (.github/run-eval/resolve_model_config.py), it should be reviewed by a human maintainer to confirm no unintended impact on benchmark results before merging.

@juanmichelini juanmichelini marked this pull request as ready for review March 10, 2026 15:00
Copy link
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Clean addition following existing pattern.

This change is technically sound and follows the established pattern perfectly. However, since this modifies evaluation harness code (.github/run-eval/resolve_model_config.py), it should be reviewed by a human maintainer to confirm no unintended impact on benchmark results before merging.

@juanmichelini juanmichelini marked this pull request as draft March 10, 2026 15:02
@juanmichelini
Copy link
Collaborator Author

@OpenHands update PR to also add a test and add it to heuristics like this PR does #2374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants