Skip to content

Migration to Gradle (new) #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Migration to Gradle (new) #100

wants to merge 33 commits into from

Conversation

@NicoPiel
Copy link

@NicoPiel NicoPiel commented May 26, 2025 •
edited
Loading

Second attempt at a migration from Ant to Gradle. Compiles and start successfully.

Use ./gradlew dist -x test (Donkey tests still fail)

Fixes #52

NicoPiel added 9 commits May 24, 2025 19:26
@NicoPiel
Migrates build system to Gradle
96aca38 
Replaces the Ant-based build system with Gradle for improved dependency management, build automation, and extensibility.

This change introduces Gradle build scripts for all subprojects, including configuration for code compilation, testing, JAR creation, and distribution. It also adds wrapper files and associated configurations to simplify build execution. The migration facilitates a more modern and maintainable build process, aligning with industry best practices and enabling future enhancements.

Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Successful build
b733d96 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Updates build to output cli and manager launchers
862b9fc 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Fixed Gradle warnings
bda9964 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Updated Gradle and disabled config cache
d79974f 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Fixed build issues
b8279bc 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Client JAR should build correctly now
b2a679a
@NicoPiel
Applied patch suggested by kayyagari
1cb0edf
@NicoPiel
Merge branch 'main' into feature/gradle-2
c4f7f3a
jbeckers
jbeckers reviewed May 27, 2025
View reviewed changes
jbeckers
jbeckers reviewed May 27, 2025
View reviewed changes
Copy link

@jbeckers jbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

I'm curious what the diff would be between the official mirth 4.5.2 distribution and the result of this gradle build. I'll see if I can find some time to experiment this weekend.

NicoPiel added 14 commits June 3, 2025 23:14
@NicoPiel
Fixed some build problems
a6fa6a3
@NicoPiel
Added Gradle to .sdkmanrc
ed575c7
@NicoPiel
Migrates build system to Gradle
85d063c 
Replaces the Ant-based build system with Gradle for improved dependency management, build automation, and extensibility.

This change introduces Gradle build scripts for all subprojects, including configuration for code compilation, testing, JAR creation, and distribution. It also adds wrapper files and associated configurations to simplify build execution. The migration facilitates a more modern and maintainable build process, aligning with industry best practices and enabling future enhancements.

Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Successful build
556fe86 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Updates build to output cli and manager launchers
7aeaaad 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Fixed Gradle warnings
246d084 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Updated Gradle and disabled config cache
ea107de 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Fixed build issues
72adcc0 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Client JAR should build correctly now
eb0a833
@NicoPiel
Applied patch suggested by kayyagari
7d44da8
@NicoPiel
Fixed some build problems
095aa40
@NicoPiel
Added Gradle to .sdkmanrc
60b3cba
@NicoPiel
Merge remote-tracking branch 'origin/feature/gradle-2' into feature/g…
e8ffbf7 
…radle-2
@NicoPiel
More streamlining
39cfd15 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@mgaffigan mgaffigan mentioned this pull request Jun 11, 2025
Open
jonbartels
jonbartels requested changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@jonbartels jonbartels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some trivial comments on project files and on the generated Java source files from Gradle.

I will need to do some builds and think about how to test that Gradle is producing a correct OIE build.

@NicoPiel
Delete .vscode/settings.json
c5d4f3f 
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel added 6 commits July 15, 2025 16:43
@NicoPiel
Removed generated files
9ceb59f 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Got rid of utilities
45d896a 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Merge branch 'main' into feature/gradle-2
989d332
@NicoPiel
Tests run, but many fail
96009e7 
Excluded Donkey tests
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Disabled all *Tests and crypto tests
4102473 
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@NicoPiel
Only include *Test
4c58837 
Doing it the other way around now
Signed-off-by: Nico Piel <nicopiel@mailbox.org>
@jonbartels jonbartels added this to the Next Release + 1 milestone Aug 5, 2025
@jonbartels jonbartels mentioned this pull request Aug 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonygermano tonygermano tonygermano left review comments

@jonbartels jonbartels jonbartels requested changes

+1 more reviewer

@jbeckers jbeckers jbeckers left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Next Release + 1

Development

Successfully merging this pull request may close these issues.

[IDEA] Introduce Dependency Management (e.g. Gradle or Maven)

4 participants

@NicoPiel @jbeckers @jonbartels @tonygermano